fix: preserve windows file paths #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a filepath, not a unixfs path.
aschmahmann
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Seems reasonable to me. Is there a way I can see this expressed in go-ipfs/any idea what types of things would have been going wrong before that won't now?
It seems like we should be fixing a Windows bug here, but given the lack of automated Windows tests in go-ipfs I'm wondering if we did anything weird there to offset this if this was a problem.
|
I don't think this makes a difference in most cases because windows doesn't care about I'm fixing this because the tests are failing because an error doesn't match what we expect (because the path is getting converted). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a filepath, not a unixfs path.