Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): return error in case of panic #250

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

fabiobozzo
Copy link
Contributor

@fabiobozzo fabiobozzo commented Apr 5, 2024

Address issue: #249

The new tests cover a case of sync http commands (e.g. /cat) and 'progress' commands (e.g. /add) panicking.

Copy link

welcome bot commented Apr 5, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@fabiobozzo fabiobozzo force-pushed the feat/return-http-error-if-panic branch from 6d4811e to 4d42df5 Compare April 10, 2024 13:59
@Stebalien
Copy link
Member

Thanks!

@Stebalien Stebalien merged commit dca860d into ipfs:master Apr 15, 2024
9 checks passed
@Stebalien Stebalien mentioned this pull request Apr 15, 2024
@Stebalien
Copy link
Member

(and thanks for writing a test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants