fix: OptionalString String() default

#153 (review)
ipfs · Oct 29, 2021 · 5861089 · 5861089
1 parent eb0d046
commit 5861089
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/types.go b/types.go
@@ -358,7 +358,7 @@ func (p *OptionalString) UnmarshalJSON(input []byte) error {
 
 func (p OptionalString) String() string {
 	if p.value == nil {
-		return ""
+		return "default"
 	}
 	return *p.value
 }

diff --git a/types_test.go b/types_test.go
@@ -409,8 +409,8 @@ func TestOptionalString(t *testing.T) {
 	if val := defaultOptionalString.WithDefault(""); val != "" {
 		t.Errorf("optional string should have been empty, got %s", val)
 	}
-	if val := defaultOptionalString.String(); val != "" {
-		t.Fatalf("default optional string should be an empty string, got %s", val)
+	if val := defaultOptionalString.String(); val != "default" {
+		t.Fatalf("default optional string should be the 'default' string, got %s", val)
 	}
 	if val := defaultOptionalString.WithDefault("foo"); val != "foo" {
 		t.Errorf("optional string should have been foo, got %s", val)