This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
wire a context in most of the ipfs data pipeline #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master issue: ipfs/kubo#6803 This only do the wiring. Actual usage for cancellation, logging or tracing is left for a future work.
gammazero
added
the
status/blocked
This was referenced May 13, 2021
|
@gammazero: thanks for handling. Just so I have context, did you pick this up because you saw the problem when looking somewhere else, or is this connected with other work you're doing? I do want to complete ipfs/kubo#6803 and want to make sure have the context of anything else depending on it or involved. |
|
@BigLep I did this because the code has changed enough where the old PR this replaces was based on code that no longer exists. So, I thought since I was the one who changed all the code, I should update or replace that PR so that it is ready to go if/when we decide to move forward with ipfs/kubo#6803 This PR is not connected to anything I need or am working on. It is only for ipfs/kubo#6803 |
|
Rock on - thanks for seeing it and tackling it.
…On Wed, May 19, 2021 at 5:13 PM Andrew Gillis ***@***.***> wrote:
@BigLep <https://github.com/BigLep> I did this because the code has
changed enough where the old PR
<#3> this replaces was based
on code that no longer exists. So, I thought since I was the one who
changed all the code, I should update or replace that PR so that it is
ready to go if/when decide to move forward with ipfs/kubo#6803
<ipfs/kubo#6803>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAU3I6YZAGSYGNF6ZSILDTTORHY5ANCNFSM443JXV3Q>
.
|
|
Handled by #18 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master issue: ipfs/kubo#6803
This only does the wiring. Actual usage for cancellation, logging, or tracing is
left for future work.
This PR replaces #3