Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text contrast for dark mode #8027

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Fix text contrast for dark mode #8027

merged 1 commit into from
Mar 29, 2021

Conversation

RubenKelevra
Copy link
Contributor

fixes #8024

@RubenKelevra
Copy link
Contributor Author

Todo: Add CID to the IPFS-Websites cluster

@RubenKelevra RubenKelevra mentioned this pull request Mar 25, 2021
Closed
@ligi
Copy link

ligi commented Mar 25, 2021

Thanks for the fast PR - but I think the contrast should be even stronger

@RubenKelevra RubenKelevra marked this pull request as draft March 25, 2021 14:10
@RubenKelevra
Copy link
Contributor Author

ok

@RubenKelevra
Copy link
Contributor Author

@ligi not super beautiful but the contrast is there :D

https://github.com/ipfs/go-ipfs/blob/550195129908b2e8f502bd7fd3e1ea46a0cf38d0/README.md

@ligi
Copy link

ligi commented Mar 25, 2021

I think it's nice now!

@RubenKelevra
Readme: replace header image for dark mode
db58dbc 
- Fix text contrast for dark mode and dimmed mode with white outlines around the black text

fixes ipfs#8024
@RubenKelevra RubenKelevra reopened this Mar 25, 2021
@RubenKelevra
Copy link
Contributor Author

I think this one is much better:

https://github.com/ipfs/go-ipfs/blob/db58dbc6257a5319564fd80b50770ce012e5af5f/README.md

@RubenKelevra RubenKelevra marked this pull request as ready for review March 25, 2021 14:43
@RubenKelevra
Copy link
Contributor Author

@ligi your opinion?

Stebalien
Stebalien approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version LGTM. I'm going to merge this as "it works" and we can always make followup PR to increase the contrast.

@Stebalien Stebalien merged commit bc2cc9b into ipfs:master Mar 29, 2021
@Stebalien
Copy link
Member

@RubenKelevra I'm having trouble finding the xcf version on the network.

@RubenKelevra
Copy link
Contributor Author

@RubenKelevra I'm having trouble finding the xcf version on the network.

Strange, I actually pinned it on two nodes and pinata to be sure it's available. 🤔

Via the pinata gateway I'm able to download it:

https://gateway.pinata.cloud/ipfs/bafykbzacecaesuqmivkauix25v6i6xxxsvsrtxknhgb5zak3xxsg2nb4dhs2u

@Stebalien
Copy link
Member

Ah, and our gateways are peered with pinata which makes everything "just work" (unless I want to pin it from my machine...).

This appears to fall into the category of "pinata has too many things to announce to the network".

@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README in github dark mode
3 participants
@RubenKelevra @ligi @Stebalien