Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README in github dark mode #8024

Closed
ligi opened this issue Mar 25, 2021 · 4 comments · Fixed by #8027
Closed

README in github dark mode #8024

ligi opened this issue Mar 25, 2021 · 4 comments · Fixed by #8027
Labels
need/triage Needs initial labeling and prioritization topic/docs-ipfs Topic docs-ipfs

Comments

@ligi
Copy link

ligi commented Mar 25, 2021

no biggie - just noticed it - since github has a dark mode now the contrast here can be a problem:

Selection_075

a simple color change can fix this
@ligi ligi added need/triage Needs initial labeling and prioritization topic/docs-ipfs Topic docs-ipfs labels Mar 25, 2021
RubenKelevra added a commit to RubenKelevra/ipfs_kubo that referenced this issue Mar 25, 2021
@RubenKelevra
Fix text contrast for dark mode
6549a63 
fixes ipfs#8024
@RubenKelevra RubenKelevra mentioned this issue Mar 25, 2021
Merged
@RubenKelevra

This comment has been minimized.

Sign in to view
@ligi
Copy link
Author

ligi commented Mar 25, 2021

done

RubenKelevra added a commit to RubenKelevra/ipfs_kubo that referenced this issue Mar 25, 2021
@RubenKelevra
Readme: replace header image for dark mode
c2cfd19 
- Fix text contrast for dark mode and dimmed mode with white outlines around the black text

fixes ipfs#8024
RubenKelevra added a commit to RubenKelevra/ipfs_kubo that referenced this issue Mar 25, 2021
@RubenKelevra
Readme: replace header image for dark mode
db58dbc 
- Fix text contrast for dark mode and dimmed mode with white outlines around the black text

fixes ipfs#8024
@RubenKelevra
Copy link
Contributor

I pushed a third version to the PR:

Screenshot_20210328_235303

@ligi
Copy link
Author

ligi commented Mar 28, 2021

even nicer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix text contrast for dark mode RubenKelevra/ipfs_kubo
2 participants
@ligi @RubenKelevra