Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

[WIP] remove UnixfsNode from trickledag #10

Closed
wants to merge 3 commits into from
Closed

[WIP] remove UnixfsNode from trickledag #10

wants to merge 3 commits into from

Commits on Nov 12, 2018

  1. dag: add fsNodeType in NewLeafNode and NewLeafDataNode 

    NewLeafNode and NewLeafDataNode is introduced in commit 474b77a2bdb1c
("importer: remove `UnixfsNode` from the balanced builder"). It is
intended to return ipfs.Node instead of UnixfsNode. But it only
support creating the TFile leaf node for merkledag.

This commit add fsNodeType to above two functions and update the code
in dagbuild.go. Further patches of trickledag will make use of them
and pass TRaw to create leaf node.

License: MIT
Signed-off-by: Bamvor Zhang <[email protected]>
    Bamvor Zhang committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    82c8bb7 View commit details
    Browse the repository at this point in the history

  2. Docs: update balanced builder document 

    After fsNodeType in NewLeafNode is supported by commit 85897b3
("dag: add fsNodeType in NewLeafNode and NewLeafDataNode"). Move
comments in NewLeafNode to importer/balanced/builder.go to clarify
why TFile is used by balanced builder as leaves.

License: MIT
Signed-off-by: Bamvor Zhang <[email protected]>
    Bamvor Zhang committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    b8a9032 View commit details
    Browse the repository at this point in the history

  3. dag: remove UnixfsNode in Layout of trickledag 

    This patch is the part of trickledag work which is similar to the
merkledag work in commit 474b77a2bdb1c ("importer: remove `UnixfsNode`
from the balanced builder"). Two helper functions(fillTrickleRecFSNode
and FillFSNodeLayer) is introduced temporarily for modifing the Layout
functions. These two funtions will be removed when all the code of
UnixfsNode is removed in trickledag.go.

Test ipfs add and get commands to check whether get the same hash of
file after the code changes.

License: MIT
Signed-off-by: Bamvor Zhang <[email protected]>
    Bamvor Zhang committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    ab44352 View commit details
    Browse the repository at this point in the history