-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy window.ipfs examples #172
Labels
Comments
@lidel - I added the remaining (quick) docs mods to your original checklist, plus a suggestion to move https://github.com/ipfs-shipyard/demo-ipfs-todo repo into the |
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this issue
Feb 19, 2022
- removed yarn and all the hackery around transitive dependency overrides - bumped all dependencies - switched to ipfs-core for less deps - removed unused deps - Firefox manifest fix to pass latest webext lint - removed remaining window.ipfs code that was pulling dead dependencies (ipfs/in-web-browsers#172) TODO: - fix tests - docker builds - browserAction icon
19 tasks
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this issue
Feb 19, 2022
- removed yarn and all the hackery around transitive dependency overrides - bumped all dependencies - switched to ipfs-core for less deps - removed unused deps - Firefox manifest fix to pass latest webext lint - removed remaining window.ipfs code that was pulling dead dependencies (ipfs/in-web-browsers#172) TODO: - fix tests - docker builds - browserAction icon
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this issue
Sep 26, 2022
- removed yarn and all the hackery around transitive dependency overrides - bumped all dependencies - switched to ipfs-core for less deps - removed unused deps - Firefox manifest fix to pass latest webext lint - removed remaining window.ipfs code that was pulling dead dependencies (ipfs/in-web-browsers#172) TODO: - fix tests - docker builds - browserAction icon
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this issue
Nov 22, 2022
- removed yarn and all the hackery around transitive dependency overrides - bumped all dependencies - switched to ipfs-core for less deps - removed unused deps - firefox manifest fix to pass latest webext lint - removed remaining window.ipfs code that was pulling dead dependencies (ipfs/in-web-browsers#172) - fixed tests (#1101) - and much more Co-authored-by: Nishant Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ipfs/ipfs-companion#589 (comment):
Given that it has been off for most of this year and nobody complained,
I'll be removing its presence from our docs and codebases:
- switch https://docs.ipfs.io/how-to/companion-window-ipfs/ to be unlisted (removing from https://github.com/ipfs/ipfs-docs/blob/ec9655e11580af1a897ec7b004c863eb24f4cee1/docs/.vuepress/config.js takes it out of the nav, BUT it'll still show up in Algolia search)
- truncate content to just inform about what it was (could be a rephrasing of first two sentences in text quoted on top of this issue)
- remove reference in https://github.com/ipfs/ipfs-docs/blob/2cb827752782545914b184a9c04a41cbbda5dc37/docs/reference/js/api.md
- remove reference in https://github.com/ipfs/ipfs-docs/blob/606cfdff028e3a7599f7199a13737ac3bca19598/docs/how-to/companion-node-types.md
ipfs-inactive
org@jessicaschilling I can do the code cleanup, but you may be more familiar with the docs – is the page I linked the only place where we mention it?The text was updated successfully, but these errors were encountered: