Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting ipfs daemon sometimes freezes the browser #360

Closed
magik6k opened this issue Jan 22, 2018 · 10 comments · Fixed by #608
Closed

Restarting ipfs daemon sometimes freezes the browser #360

magik6k opened this issue Jan 22, 2018 · 10 comments · Fixed by #608
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@magik6k
Copy link
Member

magik6k commented Jan 22, 2018

When restarting the local daemon (killing it and starting back after 10-30s), the browser will occasionally freeze for a few seconds.

ipfs-companion 2.1.0
Firefox 57.0.4
os/wm: Arch Linux/bspwm

@lidel
Copy link
Member

lidel commented Jan 22, 2018

I suspect this got fixed in past weeks.
Are you able to re-check with v2.2.0beta1 (from Development Channel)?
If the issue is still present, are you running multiprocess (about:support → "Multiprocess Windows")?

@lidel lidel self-assigned this Jan 22, 2018
@lidel lidel added kind/bug A bug in existing code (including security flaws) UX labels Jan 22, 2018
@magik6k
Copy link
Member Author

magik6k commented Feb 8, 2018

So I've been running v2.2.0beta1 for some time on FF 58 now, and it is still an issue. Yes, it's running multiprocess. The issue is still there.

@lidel
Copy link
Member

lidel commented Feb 8, 2018

Thank you, I am looking into this as a part of stabilization efforts before v2.2.0 release. It is on our TODO list.
(FYI we should have a new beta within a week)

@lidel lidel mentioned this issue Feb 8, 2018
27 tasks
@lidel
Copy link
Member

lidel commented Apr 11, 2018

I am following up on things and I am unable to replicate this.

@magik6k any change with latest version? ('beta' and 'stable' have the same code right now)

@magik6k
Copy link
Member Author

magik6k commented Apr 11, 2018

on 2.2.0.8720 - I've had some hangs but it feels like they happen less often now. I've also noticed that I get these hangs when using 'Copy Public Gateway URL' from the context menu (might not be related to this issue).

@lidel
Copy link
Member

lidel commented Apr 11, 2018

Yeah, copying should work instantly (it does not hit API), but.. are you having issues with pinning by any chance?
Also:
Is your node's HTTP API on the same machine or are you using a remote one?
Slow/old laptop?

@magik6k
Copy link
Member Author

magik6k commented Apr 11, 2018

are you having issues with pinning by any chance?

The pin button in the extension doesn't seem to do anything for me. (pin doesn't show up in ipfs pin ls -t recursive, there is no feedback but the browser doesn't hang)

Is your node's HTTP API on the same machine or are you using a remote one?

It's on the local machine

Slow/old laptop?

I'd call it slightly overkill workstation. IPFS node sits on hdd bcache-d on an nvme ssd, using badger datastore with about 24G of data in it.

@lidel
Copy link
Member

lidel commented Apr 11, 2018

Interesting. Is there a specific IPFS Path that triggers the issue or is it purely random?

So far I've seen 'gui not being properly refreshed' once, when I was pinning root of a big directory tree that was not fully loaded into my node. Everything got back to normal after download finished, so I low-key suspect API stopped responding to new requests (for ipfs swarm peers or for ipfs pin ls <path>) when pinning of mentioned <path> was in progress. Does this sound familiar?

@magik6k
Copy link
Member Author

magik6k commented Apr 11, 2018

ipfs swarm peers should be fast, ipfs pin ls may get really slow for mid-large repos, especially when called without -t recursive flag (mine repo has few 100k's of pins, pin ls can take minutes to finish)

lidel added a commit that referenced this issue Sep 22, 2018
`pin.ls` may get really slow for mid-range repos,
so we only check for explicit (recursive) ones

Context: #360 (comment)
Closes #360
@lidel lidel added the status/deferred Conscious decision to pause or backlog label Sep 22, 2018
@lidel
Copy link
Member

lidel commented Oct 5, 2018

Reopening, for some reason parameters added in #594 do not end up in the actual HTTP request sent by js-ipfs-api.

@lidel lidel reopened this Oct 5, 2018
lidel added a commit to ipfs-inactive/js-ipfs-http-client that referenced this issue Oct 19, 2018
Solves problem described in
ipfs/ipfs-companion#360 (comment)

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
lidel added a commit that referenced this issue Oct 21, 2018
Solves problem described in
#360 (comment)
by applying fix for ipfs-api from
ipfs-inactive/js-ipfs-http-client#875

Closes #360
lidel added a commit that referenced this issue Oct 26, 2018
Solves problem described in
#360 (comment)
by applying fix for ipfs-api from
ipfs-inactive/js-ipfs-http-client#875

Closes #360
alanshaw pushed a commit to ipfs-inactive/js-ipfs-http-client that referenced this issue Oct 30, 2018
Solves problem described in
ipfs/ipfs-companion#360 (comment)

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
lidel added a commit that referenced this issue Oct 31, 2018
Solves problem described in
#360 (comment)
by applying fix for ipfs-api from
ipfs-inactive/js-ipfs-http-client#875

Closes #360
lidel added a commit that referenced this issue Oct 31, 2018
Solves problem described in
#360 (comment)
by applying fix for ipfs-api from
ipfs-inactive/js-ipfs-http-client#875

Closes #360
lidel added a commit that referenced this issue Oct 31, 2018
Solves problem described in
#360 (comment)
by applying fix for ipfs-api from
ipfs-inactive/js-ipfs-http-client#875

Closes #360
@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants