feat: recover dead sub-domain gateways #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Oct 23, 2019
There was a problem hiding this comment.
Thank you! Looks really good, small tweaks suggested in comments below.
Global style ask: please swap order in variables and labels from "subdomain public" to "public subdomain" to align with existing docs and variables (from subdomainPublicGatewayUrl to publicSubdomainGatewayUrl, from resolveToSubdomainUrl to resolveToPublicSubdomainUrl etc).
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
lidel
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Thank you!
@colinfruit please fix below labels in Preferences screen and it will be ready for merge
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #800