Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove normalizeLinksContentScript #836

Merged
merged 1 commit into from
Dec 12, 2019
Merged

fix: remove normalizeLinksContentScript #836

merged 1 commit into from
Dec 12, 2019

Commits on Dec 12, 2019

  1. fix: remove normalizeLinksContentScript 

    The script was responsible for overriding all src and href in DOM of
every page to ensure content addressed with ipfs:// URL loads.

Looking back, it does not align well with our upgrade path, and the
result across browser vendors was buggy. While it allowed loading simple
images, it did not help with broken XHR and iframe quirks and introduced
unnecessary battery drain.

Due to this, it is better to remove it and advise users to use
content-addressing at a public gateway.
This way everything works for people without IPFS client, and browsers
with IPFS support can easily detect it and upgrade the call.
    @lidel
    lidel committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    4000aba View commit details
    Browse the repository at this point in the history