Skip to content

Commit

Permalink
feat: enable pubsub via settings menu (#1735)
Browse files Browse the repository at this point in the history
* Allow enabling pubsub setting via tray preferences
* refactor: pubsub toggle triggers restart
* chore: ipfsd-ctl v7.2.0

ipfsd.stop() did not wait for proper shutdown, which caused things to go
racy during situations where we restart node.
When unlucky, I ended up with two go-ipfs processses.

Bumping version to include fix from ipfs/js-ipfsd-ctl#554

* fix: show pubsub status when starting
* refactor: avoid duplicated pubsub in logs

already logged in ./src/utils/create-toggler.js,
so here we only log status when app starts and that is all

* refactor: move pubsub to experiments

it is still an experiment in go-ipfs:
https://github.com/ipfs/go-ipfs/blob/master/docs/experimental-features.md#ipfs-pubsub

* refactor: simplify pubsub enable/disable

Co-authored-by: Marcin Rataj <[email protected]>
  • Loading branch information
andrew and lidel authored Jan 20, 2021
1 parent de2f752 commit 6dbfa13
Show file tree
Hide file tree
Showing 7 changed files with 274 additions and 104 deletions.
1 change: 1 addition & 0 deletions assets/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
"appPreferences": "App Preferences",
"launchOnStartup": "Launch at Login",
"openWebUIAtLaunch": "Open Web UI at Launch",
"pubsub": "Enable PubSub",
"ipfsCommandLineTools": "Command Line Tools",
"takeScreenshotShortcut": "Global Screenshot Shortcut",
"downloadHashShortcut": "Global Download Shortcut",
Expand Down
Loading

0 comments on commit 6dbfa13

Please sign in to comment.