Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron Builder and Travis Failures #1055

Closed
hacdias opened this issue Aug 26, 2019 · 6 comments
Closed

Electron Builder and Travis Failures #1055

hacdias opened this issue Aug 26, 2019 · 6 comments
Labels
P0 Critical: Tackled by core team ASAP

Comments

@hacdias
Copy link
Member

hacdias commented Aug 26, 2019

Right now, there are quite a few issues with our build process, CI and Electron Builder:

Fetching Web UI

Currently, the latest Web UI version is not pinned to the gateway. On normal circumstances, it should not be a problem because it's still pinned to the cluster. Although, the gateway is having issues connecting to cluster.

This makes build fails due to timeouts.

Solutions:

  1. Make webui.ipfs.io the latest released version and dev.webui.ipfs.io the latest commit. That way, both domains shall be pinned to gateway.
  2. Add a git submodule to IPFS Desktop with IPFS Web UI and build IPFS Web UI on the fly.
    • More burden when updating IPFS Web UI.

Electron Builder failing on Linux releases...

Electron builder has a bug on the latest version that makes releases fail on Travis (don't know if it happens on other CIs). Issue opened on their repo 20 days ago. No replies yet, no activity on the repo. See electron-builder#4134.

Downgrading also implicates downgrading electron which implicates changes on the code.

There's also the issue #1044, which I believe is caused by the beta binaries been built manually on a virtual machine I created because of this issue.

What to do?

Other points...

@hacdias
Copy link
Member Author

hacdias commented Aug 28, 2019

@hacdias
Copy link
Member Author

hacdias commented Aug 28, 2019

Also, just found out we can build Windows binaries on Linux through Wine!

@hacdias hacdias added the P0 Critical: Tackled by core team ASAP label Aug 29, 2019
@hacdias
Copy link
Member Author

hacdias commented Sep 2, 2019

A few updates on this issue:

  1. I've created a PR to test GitHub Actions.
  2. I've found another error in Travis logs which may be the actual cause of the error: there was a breaking change on Electron Builder which was not published as a major release. Snap packages now deploy to the snap store by default and since we didn't have the credentials to the snap store, build failed.
    • Note: I believe this is why it failed, but I'm not sure.

If 2 is true, we can keep using Travis+AppVeyor.

Anyways, I've contacted the AppVeyor support to delete the project: https://ci.appveyor.com/project/wubalubadubdub/ipfs-desktop-difec because it was created by an user called 'wubalubadubdub' which doesn't seem to have any relation to IPFS Shipyard, nor IPFS organisations.

If we decide to keep AppVeyor after that, I'll create a project for IPFS Desktop here.

  • This is blocking the next release.
  • I will be able to unblock this tonight or tomorrow with a Travis+AppVeyor setup for sure.
    • After that, I will release a pre-release and test if the setup works.
  • Still waiting for the webui.ipfs.io fix.

@hacdias
Copy link
Member Author

hacdias commented Sep 2, 2019

After running Travis+AppVeyor, I could successfully publish a 0.9.0-beta.3 prerelease which seems to indicate that our build process is fixed.

The problem with Electron Builder was, in fact, something else much easier but was buried deeper in the logs: see #1069.

@hacdias
Copy link
Member Author

hacdias commented Sep 2, 2019

Will close this for now since the issues on IPFS Desktop side seem to be solved!

@hacdias hacdias closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant