Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not upload to snap store #1069

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Sep 2, 2019

The configuration for snap says:

snap target by default publishes to snap store (the app store for Linux). To force publishing to another providers, explicitly specify publish configuration for snap.

Perhaps this is the reason why publishing is failing on Linux since the logs show there is an error while publishing to snap store.

This was a change introduced in Electron Builder v21.0.5. They should have published it as a breaking change because... it is a breaking change.

License: MIT
Signed-off-by: Henrique Dias [email protected]

License: MIT
Signed-off-by: Henrique Dias <[email protected]>
@hacdias hacdias merged commit 4036ea9 into master Sep 2, 2019
@hacdias hacdias deleted the chore/do-not-publish-snapstore branch September 2, 2019 08:44
amaury1093 added a commit to openethereum/fether that referenced this pull request Oct 31, 2019
amaury1093 added a commit to openethereum/fether that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant