fix: add folder #927
Merged
fix: add folder #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
ghost
assigned 
License: MIT Signed-off-by: Henrique Dias <[email protected]>
|
When testing, don't forget to run |
License: MIT Signed-off-by: Henrique Dias <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
olizilla
reviewed
May 31, 2019
| ] | ||
| }, async (res) => { | ||
| if (!res || res.length === 0) { | ||
| return resolve() |
There was a problem hiding this comment.
Would it be useful to make that a reject, so calling code can tell when you've cancelled? Testing out this PR the current behaviour if you hit cancel from the file dialog it leaves the drop down menu open, but if you cancel from the directory dialog it closes the drop down. I think it should close the drop down in both cases.
There was a problem hiding this comment.
The issue's on Web UI code. I'll apply a fix on Web UI soon. We shouldn't reject I think because on the browser side we just receive a null variable, not a rejection.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884.
Requires https://github.com/ipfs-shipyard/ipfs-webui/pull/1034/files.