-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add windows cmd & powershell init scripts #1496
Conversation
This is great 😊 Just one tiny text suggestion. Thanks! |
After discussing with @jessicaschilling, we came with this simple way to further help the user differentiate between which OS bash commands to use: https://i.imgur.com/nJ8JRhL.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should be good citizens and credit icon authors/sources
(eg. in JS comments)
Tux (linux mascot) can be freely used:
- https://www.wired.com/2001/03/the-story-behind-tux-the-penguin/:
On his website, Ewing grants everyone permission to use and modify the Tux image as they see fit, but he requests that he and GIMP be given credit "if someone asks."
I am not sure what is the license / source / status for the rest of icons used in this PR.
Actually ... this probably isn't going to work. Sad, but best to be cautious. Thanks @lidel for flagging. |
This reverts commit fc1ba4b.
Thanks for looking into that. I reverted the icon changes then 👍 |
Closes #1008
Screenshot of the end result:
Notes
Also changed the "Start the IPFS daemon" text to match one common use case: