Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows cmd & powershell init scripts #1496

Merged
merged 4 commits into from
May 21, 2020

Conversation

rafaelramalho19
Copy link
Contributor

@rafaelramalho19 rafaelramalho19 commented May 20, 2020

Closes #1008

Screenshot of the end result:
image

Notes

Also changed the "Start the IPFS daemon" text to match one common use case:

  • User has already started daemon, but didn't setup the headers. After setting up the headers, the user is confused why it's not working. Maybe reading the "restart daemon" will help.

src/welcome/WelcomePage.js Outdated Show resolved Hide resolved
@jessicaschilling
Copy link
Contributor

This is great 😊 Just one tiny text suggestion. Thanks!

@rafaelramalho19
Copy link
Contributor Author

After discussing with @jessicaschilling, we came with this simple way to further help the user differentiate between which OS bash commands to use: https://i.imgur.com/nJ8JRhL.png

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should be good citizens and credit icon authors/sources
(eg. in JS comments)

Tux (linux mascot) can be freely used:

I am not sure what is the license / source / status for the rest of icons used in this PR.

@jessicaschilling
Copy link
Contributor

jessicaschilling commented May 20, 2020

Actually ... this probably isn't going to work.
Apple icon is likely a no-go per: https://www.apple.com/legal/intellectual-property/guidelinesfor3rdparties.html
Microsoft rules are similar: https://www.microsoft.com/en-us/legal/intellectualproperty/trademarks/usage/general.aspx

Sad, but best to be cautious. Thanks @lidel for flagging.

@rafaelramalho19
Copy link
Contributor Author

Thanks for looking into that. I reverted the icon changes then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API shell text does not apply to Windows
3 participants