fix: resolve e2e test failures #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
changed the title
this ensures kubo interop CI test only runs them once.. we don't want the burden of flakiness on them
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
## [4.0.1](v4.0.0...v4.0.1) (2023-06-14) CID `bafybeigs6d53gpgu34553mbi5bbkb26e4ikruoaaar75jpfdywpup2r3my` --- ### Bug Fixes * resolve e2e test failures ([#2122](#2122)) ([106627d](106627d))
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
whizzzkid
reviewed
Jun 14, 2023
| @@ -72,12 +75,16 @@ test.describe('IPNS publishing', () => { | |||
| let keyName | |||
| let ipfs | |||
| test.beforeEach(async ({ page }) => { | |||
| keyName = 'pet-name-e2e-ipns-test-' + new Date().getTime() | |||
| keyName = 'pet-name-e2e-ipns-test-' + new Date().getTime() + Math.random().toString(16).slice(2) | |||
There was a problem hiding this comment.
Isn't time randomness sufficient?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes interop test failure in ipfs/kubo#9940