Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing webworker support #120

Closed
daviddias opened this issue Mar 21, 2017 · 7 comments
Closed

Missing webworker support #120

daviddias opened this issue Mar 21, 2017 · 7 comments
Assignees
@vmx @dryajov
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P3 Low: Not priority right now

Comments

@daviddias
Copy link
Member

@daviddias daviddias mentioned this issue Mar 21, 2017
Closed
7 tasks
@daviddias
Copy link
Member Author

//cc @dryajov

@daviddias daviddias added the status/ready Ready to be worked label Apr 5, 2017
@daviddias daviddias added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue labels Apr 16, 2017
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jun 20, 2017
@daviddias
Copy link
Member Author

It works now

@daviddias daviddias reopened this Aug 25, 2017
@daviddias
Copy link
Member Author

Seems that it was a false positive. As we learned from #142, WebWorker support for Bitswap tests (at least) is not there yet.

@daviddias daviddias added exp/wizard Extensive knowledge (implications, ramifications) required status/ready Ready to be worked and removed exp/novice Someone with a little familiarity can pick up status/deferred Conscious decision to pause or backlog labels Aug 25, 2017
@dignifiedquire
Copy link
Member

It works locally, just because travis is sad doesn't mean there is an actual issue

@daviddias
Copy link
Member Author

@victorbjelkholm could you test it in your Linux env? It might be a Mac OS blessing (wouldn't be the first)

@daviddias daviddias added the P3 Low: Not priority right now label Oct 18, 2017
@daviddias
Copy link
Member Author

Ping @dryajov

@dryajov
Copy link
Member

dryajov commented Oct 18, 2017

on it.

vmx added a commit that referenced this issue Apr 16, 2018
@vmx
chore: run Browser tests with Web Workers
7801039 
Enable running the Browser tests within Web Workers.

Closes #120.
@vmx vmx mentioned this issue Apr 16, 2018
Merged
@ghost ghost assigned vmx Apr 16, 2018
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Apr 16, 2018
daviddias pushed a commit that referenced this issue Apr 24, 2018
@vmx @daviddias
chore: run Browser tests with Web Workers
2fe667b 
Enable running the Browser tests within Web Workers.

Closes #120.
@ghost ghost removed the status/in-progress In progress label Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmx vmx

@dryajov dryajov

Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P3 Low: Not priority right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vmx @dignifiedquire @dryajov @daviddias