Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce size #203

Merged
merged 4 commits into from
Dec 11, 2019
Merged

fix: reduce size #203

merged 4 commits into from
Dec 11, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Oct 19, 2019

change lodash.isequalwith for a custom much smaller function specific for this use case.

72.22KB > 67.87KB gzipped

Probably much faster also.

change lodash.isequalwith for a custom much smaller function specific for this use case.

72.22KB > 67.87KB gzipped
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@dirkmc
Copy link
Contributor

dirkmc commented Oct 21, 2019

Nice, thank you

Could you please add a test for the new function 🙏

@hugomrdias
Copy link
Member Author

@dirkmc should be ready to merge

@dirkmc dirkmc merged commit 9f818b4 into master Dec 11, 2019
@dirkmc dirkmc deleted the fix/reduce-size branch December 11, 2019 18:36
@dirkmc
Copy link
Contributor

dirkmc commented Dec 11, 2019

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants