Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass in Options Object to http Constructor #37

Merged
merged 1 commit into from
Apr 21, 2020
Merged

feat: pass in Options Object to http Constructor #37

merged 1 commit into from
Apr 21, 2020

Commits on Apr 21, 2020

  1. feat: pass in options object to http constructor 

    It looks like the function was written to allow this as a parameter, but it was never used. This should allow for use cases like specifying custom headers while using `urlSource`. The `node-fetch` module falls back on [default options](https://github.com/node-fetch/node-fetch#options) if none are specified, so we shouldn't need to check and send an empty object at this step.
    @leoherzog
    leoherzog committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    5220411 View commit details
    Browse the repository at this point in the history