Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

bootstrap #46

Closed
18 tasks done
daviddias opened this issue Jan 11, 2016 · 4 comments
Closed
18 tasks done

bootstrap #46

daviddias opened this issue Jan 11, 2016 · 4 comments
Labels
exp/novice Someone with a little familiarity can pick up

Comments

@daviddias
Copy link
Member

I've started working on this on #45, but as the HTTP API is in flux/being written (between a RPC vs REStful discussion), I'm going to defer this until that part is spec.

Whole spec ipfs/specs#65
HTTP API spec - https://github.com/ipfs/api

  • add
    • core
      • tests
    • http-api
      • tests
    • cli
      • tests
  • rm
    • core
      • tests
    • http-api
      • tests
    • cli
      • tests
  • list
    • core
      • tests
    • http-api
      • tests
    • cli
      • tests
@daviddias daviddias mentioned this issue Jan 11, 2016
31 tasks
@RichardLitt
Copy link
Member

Ahh, so this is why you've been trying to get the API moving faster. ;)

@daviddias
Copy link
Member Author

It definitely helps everyone. js-ipfs-api and the other client libraries keep getting broken

@jbenet
Copy link
Member

jbenet commented Jan 13, 2016

but as the HTTP API is in flux/being written (between a RPC vs REStful discussion),

I thought we agreed that it was going to remain as is (a rest like thing) and we would only add a "single endpoint json rpc" api as another thing.

@daviddias daviddias changed the title Implement the HTTP endpoints for ipfs bootstrap feature: bootstrap Jan 14, 2016
@daviddias daviddias added help wanted exp/novice Someone with a little familiarity can pick up labels Jan 26, 2016
@daviddias daviddias changed the title feature: bootstrap bootstrap Feb 23, 2016
@daviddias
Copy link
Member Author

This is now complete

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this issue May 22, 2020
If you have a shard like:

```
F1
  A0
    C8myfile
```

And you add a file that causes `C8myfile` to become a subshard, previously
you would end up with this:

```
F1
  A0
    C8
      C8
        B3myfile
        82newfile
```

This PR ensures you get the correct structure:

```
F1
  A0
    C8
      B3myfile
      82newfile
```

When we update a shard, we re-create a portion of the shard in order to
update the existing structure, this avoids loading the entire shard which
could be expensive.  Previously we weren't descending into the newly
created sub-shard to add the correct portion to the existing shard.

Fixes ipfs#45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up
Projects
None yet
Development

No branches or pull requests

3 participants