fresh install of IPFS as dep results in older version of async

[pgte]

Fresh install of IPFS as a dependency results in an installed version that resolved async to version 1.5.2.

Symptom: when browserifying the app, the following error occurs:

Error: Cannot find module 'async/each' from '/Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/libp2p/src'
    at /Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:123:15)

When starting IPFS from within the node_modules/ipfs dir:

→ node ./node_modules/ipfs/src/core/index.js
module.js:471
    throw err;
    ^

Error: Cannot find module 'async/setImmediate'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/pedroteixeira/demos/ipfs-pubsub-demo/node_modules/libp2p/src/index.js:6:22)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

[pgte]

Here is what an npm ls async looks like at the app folder:

[email protected] /Users/pedroteixeira/demos/ipfs-pubsub-demo
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected] 
└─┬ [email protected]
  ├── [email protected] 
  ├─┬ [email protected]
  │ ├── [email protected] 
  │ └─┬ [email protected]
  │   └── [email protected] 
  ├─┬ [email protected]
  │ ├── [email protected] 
  │ └─┬ [email protected]
  │   └── [email protected] 
  ├─┬ [email protected]
  │ ├── [email protected] 
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ ├─┬ [email protected]
  │ │ └─┬ [email protected]
  │ │   └── [email protected] 
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ └─┬ [email protected]
  │   └── [email protected] 
  ├─┬ [email protected]
  │ └── [email protected] 
  ├─┬ [email protected]
  │ ├── [email protected] 
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ ├─┬ [email protected]
  │ │ └─┬ [email protected]
  │ │   └── [email protected] 
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ ├─┬ [email protected]
  │ │ ├── [email protected] 
  │ │ ├─┬ [email protected]
  │ │ │ └── [email protected] 
  │ │ └─┬ [email protected]
  │ │   └── [email protected] 
  │ ├─┬ [email protected]
  │ │ ├─┬ [email protected]
  │ │ │ ├─┬ [email protected]
  │ │ │ │ ├─┬ [email protected]
  │ │ │ │ │ └── [email protected] 
  │ │ │ │ └─┬ [email protected]
  │ │ │ │   ├─┬ [email protected]
  │ │ │ │   │ └── [email protected] 
  │ │ │ │   └── [email protected] 
  │ │ │ ├─┬ [email protected]
  │ │ │ │ └── [email protected] 
  │ │ │ └─┬ [email protected]
  │ │ │   ├── [email protected] 
  │ │ │   └─┬ [email protected]
  │ │ │     └── [email protected] 
  │ │ └── [email protected] 
  │ └─┬ [email protected]
  │   ├── [email protected] 
  │   └─┬ [email protected]
  │     └── [email protected] 
  ├─┬ [email protected]
  │ ├── [email protected] 
  │ └─┬ [email protected]
  │   ├── [email protected] 
  │   └─┬ [email protected]
  │     └── [email protected] 
  ├─┬ [email protected]
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ ├─┬ [email protected]
  │ │ ├── [email protected] 
  │ │ └─┬ [email protected]
  │ │   └── [email protected] 
  │ └─┬ [email protected]
  │   └── [email protected] 
  ├─┬ [email protected]
  │ └─┬ [email protected]
  │   ├── [email protected] 
  │   └─┬ [email protected]
  │     └── [email protected] 
  └─┬ [email protected]
    └── [email protected] 

[daviddias]

just quickly published a patch version on libp2p. Could you try to do a fresh npm install on js-ipfs latest master? I'm trying figuring out why that error 'today', since we had fixed all the async/setImmediate a while ago. Did you change your npm version?

[pgte]

I've nailed it down to this issue occurring in libp2p v0.9.1: libp2p/js-libp2p#108

[daviddias]

Not running tests with browserify keeps biting us. Would love to have this as part of aegir -> ipfs/aegir#102

[daviddias]

Won't be an issue once 0.25 is released (tomorrow) #910 🎉 thanks for catching it!