test: use os.tmpdir() #1126
test: use os.tmpdir() #1126
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 122 122
Lines 2732 2732
=======================================
Hits 2281 2281
Misses 451 451Continue to review full report at Codecov.
|
test/cli/daemon.js
Outdated
| @@ -65,7 +65,7 @@ describe('daemon', () => { | |||
| let ipfs | |||
|
|
|||
| beforeEach(() => { | |||
| repoPath = '/tmp/ipfs-test-not-found-' + Math.random().toString().substring(2, 8) | |||
| repoPath = path.join(os.tmpdir(), 'ipfs-test-not-found-' + Math.random().toString().substring(2, 8)) | |||
There was a problem hiding this comment.
If you don't mind here as well (ref ipfs-inactive/ipfs-performance-profiling#12 (comment))
test/core/create-node.spec.js
Outdated
| @@ -19,7 +21,7 @@ describe('create node', function () { | |||
| this.timeout(80 * 1000) | |||
|
|
|||
| const node = new IPFS({ | |||
| repo: '/tmp/ipfs-repo-' + Math.random(), | |||
| repo: path.join(os.tmpdir(), 'ipfs-repo-' + Math.random()), | |||
There was a problem hiding this comment.
one more (ref: ipfs-inactive/ipfs-performance-profiling#12 (comment))
There was a problem hiding this comment.
@diasdavid Good idea. I don't like seeing Math.random, because I always worry if a cryptographically secure P/RNG should be used.
|
Seems like CI uses windows-386 and currently there is no go-ipfs build available due to: ipfs/distributions#165 |
|
@diasdavid Yes, 386 builds are failing, I added #1127 |
See #1075