This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix(core/components/dag): fix default hash algorithm for put() api #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we've introduced a little bug in ipfs@d299ed7 in which the default hash algorithm has a typo. This didn't fail on CI because the `options.hashAlg` passed down to `ipld.put()` is actually not being used at time of this commit. For more info see: https://github.com/ipld/js-ipld/blob/d3d78e053ebd3f8c85a8b5579715be8812773d4d/src/index.js#L236-L239 License: MIT Signed-off-by: Pascal Precht <[email protected]>
|
@alanshaw sorry this one slipped through 🙇🏻♂️ |
alanshaw
approved these changes
Jul 4, 2018
|
Good catch, thank you 🚀 . Would you be willing to add a test to |
|
I can certainly do that. But just to clarify: You want a test that simply checks whether a non-default hashAlg is used? Cause that's kind of covered in the existing tests: https://github.com/ipfs/interface-ipfs-core/blob/master/js/src/dag/put.js#L55-L81 Although, those don't really check if the resulting Maybe it makes sense to change those to look more like the one here? https://github.com/ipfs/interface-ipfs-core/blob/master/js/src/dag/put.js#L103-L110 Otherwise I can also just add a new one that checks on the resolved CID similar to the one above. |
0x-r4bbit
added a commit
to 0x-r4bbit/interface-ipfs-core
that referenced
this pull request
Jul 4, 2018
As discussed in ipfs/js-ipfs#1419 (comment) at the time of this commit, `dag.put()` basically ignores the `hashAlg` option, as it passes it down to `ipld.put()`, which won't honor it until ipld/js-ipld#133 is merged. Once ipld/js-ipld#133 is merged, this test verifies that e.g. ``` dag.put(cborNode, { format: 'dag-cbor', hashAlg: 'sha3-512' }, (err, cid) => { ... }) ``` Actually results in a `CID` instance that decodes to `sha3-512` and not the `sha2-256` default. License: MIT Signed-off-by: Pascal Precht [email protected]
0x-r4bbit
added a commit
to 0x-r4bbit/interface-ipfs-core
that referenced
this pull request
Jul 4, 2018
As discussed in ipfs/js-ipfs#1419 (comment) at the time of this commit, `dag.put()` basically ignores the `hashAlg` option, as it passes it down to `ipld.put()`, which won't honor it until ipld/js-ipld#133 is merged. Once ipld/js-ipld#133 is merged, this test verifies that e.g. ``` dag.put(cborNode, { format: 'dag-cbor', hashAlg: 'sha3-512' }, (err, cid) => { ... }) ``` Actually results in a `CID` instance that decodes to `sha3-512` and not the `sha2-256` default. License: MIT Signed-off-by: Pascal Precht [email protected]
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 5, 2018
As discussed in ipfs/js-ipfs#1419 (comment) at the time of this commit, `dag.put()` basically ignores the `hashAlg` option, as it passes it down to `ipld.put()`, which won't honor it until ipld/js-ipld#133 is merged. Once ipld/js-ipld#133 is merged, this test verifies that e.g. ``` dag.put(cborNode, { format: 'dag-cbor', hashAlg: 'sha3-512' }, (err, cid) => { ... }) ``` Actually results in a `CID` instance that decodes to `sha3-512` and not the `sha2-256` default. License: MIT Signed-off-by: Pascal Precht [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we've introduced a little bug in d299ed7
in which the default hash algorithm has a typo.
This didn't fail on CI because the
options.hashAlgpassed down toipld.put()is actually not being used at time of this commit.
For more info see: https://github.com/ipld/js-ipld/blob/d3d78e053ebd3f8c85a8b5579715be8812773d4d/src/index.js#L236-L239
License: MIT
Signed-off-by: Pascal Precht [email protected]