Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore(README): Add migration note about upgrading from < 0.30.0 #1450

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

0x-r4bbit
Copy link
Contributor

Closes #1444

License: MIT
Signed-off-by: Pascal Precht [email protected]

@0x-r4bbit 0x-r4bbit force-pushed the chore/add-installation-note branch 2 times, most recently from 336beb7 to 2499b0a Compare July 18, 2018 08:53
@alanshaw
Copy link
Member

We need to indicate that this only applies to people who are building or running IPFS from source, if you npm install ipfs this isn't an issue.

@0x-r4bbit
Copy link
Contributor Author

Very correct.

This can cause problems during installation of npm dependencies, in case the repository is not freshly cloned.

I thought ^ would clarify that. Let me add another note that makes it clear.

@0x-r4bbit 0x-r4bbit force-pushed the chore/add-installation-note branch from 2499b0a to d935216 Compare July 18, 2018 10:52
@alanshaw
Copy link
Member

Much clearer, thanks!

@alanshaw alanshaw merged commit 48aceb1 into ipfs:master Jul 18, 2018
@0x-r4bbit 0x-r4bbit deleted the chore/add-installation-note branch July 18, 2018 12:11
vmx added a commit that referenced this pull request Jul 20, 2018
As we use version ranges for dependencies, it is automatically fixed now.

Revert "docs: add migration note about upgrading from < 0.30.0 (#1450)"

This reverts commit 48aceb1.
vmx added a commit that referenced this pull request Jul 20, 2018
This issue was fixed upstream. As we use version ranges for dependencies,
it is automatically fixed now. Hence reverting the original commit.

Revert "docs: add migration note about upgrading from < 0.30.0 (#1450)"

This reverts commit 48aceb1.
vmx added a commit that referenced this pull request Jul 20, 2018
This reverts commit 48aceb1.

This issue was fixed upstream. As we use version ranges for dependencies,
it is automatically fixed now. Hence reverting the original commit.
vmx added a commit that referenced this pull request Jul 20, 2018
This reverts commit 48aceb1.

This issue was fixed upstream in git-validate with the release of
version 2.2.4. AEgir 15.0.1 uses that fixed release. As we use
version ranges for dependencies, it is automatically fixed now.
Hence reverting the original commit.
alanshaw pushed a commit that referenced this pull request Jul 20, 2018
#1456)

This reverts commit 48aceb1.

This issue was fixed upstream in git-validate with the release of
version 2.2.4. AEgir 15.0.1 uses that fixed release. As we use
version ranges for dependencies, it is automatically fixed now.
Hence reverting the original commit.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants