-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: show Web UI url in daemon output #1595
Conversation
While thinking about this, I came up with what I'd actually like to see in my console... $ jsipfs daemon
Starting IPFS daemon
Peer ID QmNTAZYQ5rtaoFtryAX2h9dycuBjhVgXtjPVZNYuMHMBw8
Swarm address /ip4/127.0.0.1/tcp/4003/ws/ipfs QmNTAZYQ5rtaoFtryAX2h9dycuBjhVgXtjPVZNYuMHMBw8
Swarm address /ip4/127.0.0.1/tcp/4002/ipfs/QmNTAZYQ5rtaoFtryAX2h9dycuBjhVgXtjPVZNYuMHMBw8
Swarm address /ip4/192.168.1.244/tcp/4002/ipfs/QmNTAZYQ5rtaoFtryAX2h9dycuBjhVgXtjPVZNYuMHMBw8
Gateway /ip4/127.0.0.1/tcp/9090
API /ip4/127.0.0.1/tcp/5002
Web UI available at http://localhost:5002/webui
Daemon is ready It's a little different to what we have now, but I think it's worth discussing. The PR in it's current state just tides things up, but if others like the look of the above, I'll make it happen. I could even learn some Go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ❤️ all the changes in the PR.
I'm not as keen on the alignment in #1595 (comment), but I'm +1 on the addition of the peer ID.
@Stebalien would you accept a PR to make the same changes in go-ipfs?
@olizilla will you send a PR to update
js-ipfs/src/http/api/routes/webui.js
Line 23 in 52f7aa7
return reply().redirect().location('/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa') |
FYI - in the next go-ipfs, version numbers will be printed: ipfs/kubo#5503
I'd keep the "Daemon is ready" copy the same though as it's the kind of output that people might be scraping from scripts to check that it started without error, and changing it would frustrate.
That is absolutely true.
@alanshaw the alignment isn't like when people create work for everyone by aligning their variable declarations; in this case it's more like we're showing tabular data (or at least a definition list) so lets give it a table-like layout for readability. You will get a PR with a CID for the new Web UI when we fix all the issues you raised 😜 |
I'd love a |
@achingbrain the silent option should probably do this! |
Absolutely! (once go-ipfs has had it's webui version updated to the revamped version, that is...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, if I approve this it means that js-ipfs gets the nuWebUI first? APPROVE!!!!! :D
Btw, congratz again on the nuWebUI, it looks aaaamazing! :D
@olizilla I think this is going to need changes to ipfsd-ctl before we can merge it. |
Sure I'll take a look. |
- make it easier for people to discover the Web UI - tidy up inconsistencies across the log lines - add IPFS to the first line. confirm to new users they started what they expected to. fixes ipfs/ipfs-webui#815 License: MIT Signed-off-by: Oli Evans <[email protected]>
Required for ipfs/js-ipfs#1595 License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
3a4b2a9
to
c58fbbd
Compare
"API is listening..." changed to "API listening..." and no longer matches the regex. N.B. is backwards compatible with older versions of the daemon. Required for ipfs/js-ipfs#1595
License: MIT Signed-off-by: Alan Shaw <[email protected]>
package.json
Outdated
@@ -72,7 +72,7 @@ | |||
"form-data": "^2.3.2", | |||
"hat": "0.0.3", | |||
"interface-ipfs-core": "~0.78.0", | |||
"ipfsd-ctl": "~0.39.1", | |||
"ipfsd-ctl": "ipfs/js-ipfsd-ctl#fix/cli-scraping", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this released before releases js-ipfs
fixes ipfs/ipfs-webui#815
Before
After
I'd keep the "Daemon is ready" copy the same though as it's the kind of output that people might be scraping from scripts to check that it started without error, and changing it would frustrate.
License: MIT
Signed-off-by: Oli Evans [email protected]