This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: dht browser disabled #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
approved these changes
Feb 14, 2019
vasco-santos
force-pushed
the
fix/dht-browser-disabled
branch
from
c48afe6
to
c71f506
Compare
|
Thanks @daviddias I added a test running in the browser and receiving the error |
vasco-santos
force-pushed
the
fix/dht-browser-disabled
branch
from
c71f506
to
072884d
Compare
alanshaw
reviewed
Feb 18, 2019
| try { | ||
| res = await ipfs.dht.put(Buffer.from('a'), Buffer.from('b')) | ||
| } catch (err) { | ||
| expect(err).to.exist() |
There was a problem hiding this comment.
Is there an error code or message we can assert on?
There was a problem hiding this comment.
No! But, I can add it to js-libp2p. However, we will have to bump the rc. What do you think?
There was a problem hiding this comment.
We need to ensure the error is because the DHT is disabled and not because of anything else. Whatever you can do to make that happen is good 👍
vasco-santos
force-pushed
the
fix/dht-browser-disabled
branch
from
072884d
to
018a140
Compare
alanshaw
approved these changes
Feb 27, 2019
This was referenced Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libp2pdefaults were not allowing the browser config to disable thedhtfor browser nodes. This PR fixes that issue