This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Bitswap Quest #195
Merged
Bitswap Quest #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
feat/bitswap
branch
2 times, most recently
from
2320cdf
to
89de3fd
Compare
dignifiedquire
force-pushed
the
feat/bitswap
branch
from
e9d2499
to
afd63fa
Compare
DO NOT USE require for JSON FILES
dignifiedquire
force-pushed
the
feat/bitswap
branch
from
3cd7bdc
to
e804947
Compare
|
|
||
| before_script: | ||
| - export DISPLAY=:99.0 | ||
| - sh -e /etc/init.d/xvfb start | ||
|
|
||
| after_success: | ||
| - npm run coverage-publish | ||
|
|
||
| env: | ||
| - CXX=g++-4.8 |
There was a problem hiding this comment.
So that travis can build native modules (node 4 and greater require a c++ compiler for those) Details here: https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Node.js-v4-(or-io.js-v3)-compiler-requirements
There was a problem hiding this comment.
I mean, which are the native modules that we have introduced with bitswap?
There was a problem hiding this comment.
None that we really need, travis was just complaining and I wanted to fix that (those native modules are mostly used through aegir)
|
LGTM :) |
dignifiedquire
force-pushed
the
feat/bitswap
branch
from
d146326
to
ea70e0b
Compare
|
🎉 🎈 🎉 🎈 🎉 🎈 🎉 🎈 🎉 🎈 🎉 🎈 🎉 🎈 🎉 🎈 |
|
wowowowwowo :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress
TODO
statwantlistunwantwill be done laterstatwantlistunwantwill be done laterNeeds the following PRs