This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: upgrade electron examples #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
approved these changes
May 23, 2019
|
Can rebuild.sh be removed now? |
|
Can the README be updated to remove the rebuild script? We should probably also link to the example here too. |
|
PR updated and ipfs/notes#256 also updated |
alanshaw
approved these changes
May 24, 2019
daviddias
reviewed
May 24, 2019
| HOME=~/.electron-gyp npm install | ||
| ``` | ||
|
|
||
| If you find any other issue, please check the [`Electron Support` issue](https://github.com/ipfs/js-ipfs/issues/843). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade to electron 5
remove rebuild, apparently there is no need for it