This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
refactor: switch to async peer-id #2588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is WIP, needs js-libp2p to use async peer-id first License: MIT Signed-off-by: Marcin Rataj <[email protected]>
|
What would be the next step here? |
|
Can please we hold off on merging this until I also performed this upgrade but backed it out after finding that previously equal peer IDs were no longer equal because one module was using v0.12.x and another was using v0.13.x, hence the promisification of the v.0.12.x peer IDs in the codebase currently. |
|
yes, 💯, forgot to make it clear: |
daviddias
added
the
status/blocked
1 task
|
Superseded by #2680 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to async
"peer-id": "^0.13.4"I originally made this for (#2566) before I realized it does not work with other deps that use non-async
peer-id.cc @alanshaw @vasco-santos @jacobheun to be aware of this