Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Refactor refs tests #2972

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Refactor refs tests #2972

merged 3 commits into from
Apr 9, 2020

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented Apr 7, 2020

Minor changes to refs to stop using ipfs.add and ipfs.object.put in favor of ipfs.block.put with test-local formatting. Tested against go-ipfs-0.4.23 the CIDs do not change. This is result of discussions at rs-ipfs/rust-ipfs#92 (comment) and at least another PR for refs-local.js should be coming later.

Sorry for the semicolons, I don't know the semicolon insertion rules by heart :)

@koivunej
Copy link
Contributor Author

koivunej commented Apr 7, 2020

Is the aegir lint documented somewhere? For me post npm install -g aegir it'll just:

$ aegir lint
.../.npm-packages/lib/node_modules/aegir/node_modules/yargs/yargs.js:1242
      else throw err
           ^

Error: Failed to load config "standard" to extend from.
Referenced from: BaseConfig

The same happens if I try to run lerna run lint "--since" "master" as executed by CI.

@achingbrain
Copy link
Member

If you run npm run lint in the root of the repo it will print out all the linting errors. No need to install aegir globally.

@koivunej
Copy link
Contributor Author

koivunej commented Apr 7, 2020

The build is now failing for a dht test failure, something failed with chrome but the related tests passed, interop failure looks transient (failed between two go-ipfs nodes).

@koivunej
Copy link
Contributor Author

koivunej commented Apr 8, 2020

@achingbrain thanks for the previous tip of npm run lint; I had only tried npm lint and then decided to go ahead with aegir but your hint made me realized I had not executed npm install so there's that :)

@achingbrain achingbrain merged commit b4c021d into ipfs:master Apr 9, 2020
@koivunej koivunej deleted the refactor_refs_tests branch April 14, 2020 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants