This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is the
The same happens if I try to run |
If you run |
The build is now failing for a dht test failure, something failed with chrome but the related tests passed, interop failure looks transient (failed between two go-ipfs nodes). |
@achingbrain thanks for the previous tip of |
hugomrdias
approved these changes
Apr 9, 2020
This was referenced Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to refs to stop using
ipfs.add
andipfs.object.put
in favor ofipfs.block.put
with test-local formatting. Tested againstgo-ipfs-0.4.23
the CIDs do not change. This is result of discussions at rs-ipfs/rust-ipfs#92 (comment) and at least another PR forrefs-local.js
should be coming later.Sorry for the semicolons, I don't know the semicolon insertion rules by heart :)