Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

test: refactor for test sanity #733

Merged
merged 1 commit into from
Jan 28, 2017
Merged

Conversation

daviddias
Copy link
Member

No description provided.

@daviddias daviddias added the status/in-progress In progress label Jan 28, 2017
@@ -10,7 +10,7 @@
"libp2p-ipfs-nodejs": "libp2p-ipfs-browser",
"./src/core/default-repo.js": "./src/core/default-repo-browser.js",
"./src/core/components/init-assets.js": false,
"./test/utils/temp-repo.js": "./test/utils/temp-repo-browser.js",
"./test/utils/create-repo-node.js": "./test/utils/create-repo-browser.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this just be create-repo rather?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could, I just standardize it because we always tag node and browser everywhere to distinguish the two, if distinction needs to happen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

@@ -14,7 +14,7 @@ function createTempRepo (repoPath) {

repo.teardown = (done) => {
clean(repoPath)
done()
setImmediate(() => done())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed here now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably explain in a code-comment with reason

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just a safe guard, a best practice

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daviddias daviddias merged commit ccd8b1d into master Jan 28, 2017
@daviddias daviddias deleted the refactor/tests-structure branch January 28, 2017 16:18
@daviddias daviddias removed the status/in-progress In progress label Jan 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants