Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Awesome DHT PART I #822

Merged
merged 1 commit into from
May 19, 2017
Merged

Awesome DHT PART I #822

merged 1 commit into from
May 19, 2017

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Apr 1, 2017 •
edited by daviddias
Loading

Main work tracker: libp2p/js-libp2p-kad-dht#1

UPDATE: I (@diasdavid) have been updating and expanding this list as needed

@dignifiedquire dignifiedquire added the status/in-progress In progress label Apr 1, 2017
@dignifiedquire dignifiedquire mentioned this pull request Apr 1, 2017
Merged
38 tasks
daviddias
daviddias suggested changes Apr 16, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realised now that I've never submitted the CR :( Don't worry, I am working on it :)

src/core/components/dht.js
* @param {function(Error, Array<PeerInfo>)} [callback]
* @returns {Promise<PeerInfo>|void}
*/
findprovs: promisify((key, callback) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/findprovs/findProvs/g

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, let's keep using go-ipfs API for now - ipfs-inactive/interface-js-ipfs-core#136

src/core/components/dht.js
* @param {function(Error, Array<Multiaddr>)} [callback]
* @returns {Promise<Array<Multiaddr>>|void}
*/
findpeer: promisify((peer, callback) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/findpeer/findPeer/g

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, let's keep using go-ipfs API for now - ipfs-inactive/interface-js-ipfs-core#136

@daviddias daviddias changed the title [WIP] Awesome DHT Awesome DHT Apr 16, 2017
@dignifiedquire
Copy link
Member Author

realised now that I've never submitted the CR :( Don't worry, I am working on it :)

:D

@daviddias
Copy link
Member

Ok, here is an update:

  • DHT is integrated with js-ipfs with this PR at the core level
  • Good news is that it indeed does DHT things between js-ipfs nodes
  • Bad news is that it doesn't interop yet with go-ipfs
  • Annoying news is that it breaks silently

@daviddias daviddias mentioned this pull request Apr 16, 2017
Closed
9 tasks
@daviddias daviddias changed the title Awesome DHT Awesome DHT PART I May 19, 2017
@daviddias
Copy link
Member

This PR got quite big and caused changed throughout the libp2p interfaces, I was hoping to get this all in one release but it seems that now I'm blocking @pgte and the IIIF endeavor from moving smoothly.

I'm going to divide this endeavor in Part I and part II, Part I being all the internal pieces that were already developed and integrated and Part II will be the final interop tests and remaining pieces to make the use of DHT faster.

@daviddias daviddias merged commit 2c6c838 into master May 19, 2017
@daviddias daviddias deleted the feat/dht branch May 19, 2017 14:49
@daviddias daviddias removed the status/in-progress In progress label May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@dignifiedquire dignifiedquire

@daviddias daviddias

Labels
awesome endeavour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignifiedquire @daviddias