Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

'init' implementation. #91

Merged
merged 3 commits into from
Mar 24, 2016
Merged

'init' implementation. #91

merged 3 commits into from
Mar 24, 2016

Conversation

hackergrrl
Copy link
Contributor

This implements most of the IPFS initialization steps:

  • check for repo existance
  • generate new peer id
  • generate + write config
  • write version
  • add default assets to the repo
  • pin default assets to the repo
  • set + publish IPNS record

@hackergrrl
Copy link
Contributor Author

Depends on ipfs/js-ipfs-repo#30 getting merged to pass tests / work.

opts.bits = opts.bits || 2048

// Pre-set config values.
var config = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nicer if this was a separate json file, so it's easier/clearer when things change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@daviddias
Copy link
Member

Thank you @noffle! :D This is great. I've made some comments, seems like we need to get the files branch merged in order to unlock add default assets to the repo. Working on that right away.

Note: I broke add + pin default assets to the repo into two items.

@daviddias
Copy link
Member

@noffle, I've merged #67 so that you are not blocked for add default assets to the repo. Once that is done, let's merge this PR as well.

@hackergrrl
Copy link
Contributor Author

The latest batch of commits includes the default assets for Node-only, and tests.

} else {
return true
}
return !(key.endsWith('-node.js') || key.endsWith('-node'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hackergrrl
Copy link
Contributor Author

FYI, I still need to add the CLI and HTTP routes & tests.

@daviddias
Copy link
Member

Excellent @noffle ! This is awesome. Made a request in one of the comments, let me know if you would like do it for this PR.

Either way, let's squash all commits before the merge, please :)

@daviddias
Copy link
Member

re: #91 (comment)

Sounds good :)

@hackergrrl
Copy link
Contributor Author

Big 'ol rebase!

@hackergrrl
Copy link
Contributor Author

Clarification: I'm going to add HTTP/CLI in another PR; it's more work than I expected!

@daviddias
Copy link
Member

LGTM, going to merge :)

@daviddias daviddias merged commit da03761 into ipfs:master Mar 24, 2016
vasco-santos pushed a commit that referenced this pull request Sep 21, 2021
* Upgrade to GitHub-native Dependabot

* chore: remove ignores

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Alex Potsides <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants