Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

clean up , working builds on node v8.4.0 #980

Merged
merged 1 commit into from
Sep 3, 2017

Conversation

ya7ya
Copy link
Contributor

@ya7ya ya7ya commented Sep 2, 2017

Some clean up for gateway (tested on node v6 and v8.4.0).

Current Todo:

  • port go-ipfs gateway tests to js-ipfs

License: MIT
Signed-off-by: Yahya [email protected]

@daviddias
Copy link
Member

@ya7ya you mention tests but this PR doesn't include any. Could you confirm that you push everything you wanted?

@ya7ya
Copy link
Contributor Author

ya7ya commented Sep 2, 2017

@diasdavid I meant to say builds, It was failing in Travis CI and locally when i updated node to v8.4.0.

I'm editing this.

@ya7ya
Copy link
Contributor Author

ya7ya commented Sep 2, 2017

@diasdavid sorry. nvm, I committed this too soon , It's failing tests here but it worked locally, investigating issue...

@daviddias
Copy link
Member

Hi @ya7ya, I believe it is failing because it needs the need master (due ot ipfs-api release updates). I'm going to merge this into the branch and then do a master rebase and we shall see :)

@daviddias daviddias merged commit 455f14d into ipfs:feat/gateway Sep 3, 2017
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
This switches pull-to-stream to v0.1.1 which includes
a fix for ipfs#967

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants