This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Create git-ipld example #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/traverse-ipld-graphs/git.js
Outdated
|
|
||
| multihashing(data, 'sha1', (err, multihash) => { | ||
| if (err) { | ||
| cb(err) |
There was a problem hiding this comment.
Done, the same thing is in eth.js
daviddias
suggested changes
Sep 5, 2017
There was a problem hiding this comment.
This is super, @magik6k. Thank you so much! <3
Note how all the other examples are listed on the README -- https://github.com/ipfs/js-ipfs/tree/master/examples/traverse-ipld-graphs --, could you at an item too?
magik6k
force-pushed
the
feat/git-example
branch
from
8e96b1c
to
a234378
Compare
daviddias
approved these changes
Sep 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #979
I needed to add
"multicodec": "~0.1.9",to my package.json as npm kept downloading 0.1.8, should I PR that here too?