Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows interop #171

Merged
merged 3 commits into from
Nov 12, 2017
Merged

Windows interop #171

merged 3 commits into from
Nov 12, 2017

Conversation

richardschneider
Copy link
Contributor

@richardschneider richardschneider commented Nov 12, 2017 •
edited
Loading

Background discussion on ipfs-inactive/js-ipfs-http-client#623

@ghost ghost added the status/in-progress In progress label Nov 12, 2017
daviddias
daviddias approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) just going to wait for CI

@daviddias daviddias merged commit 0561798 into master Nov 12, 2017
@daviddias daviddias deleted the windows-interop branch November 12, 2017 13:05
@ghost ghost removed the status/in-progress In progress label Nov 12, 2017
@richardschneider
Copy link
Contributor Author

richardschneider commented Nov 16, 2017 •
edited
Loading

This should help #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

@thisconnect thisconnect Awaiting requested review from thisconnect

Assignees

@richardschneider richardschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardschneider @daviddias