Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kill disposable nodes on stop and simplify started status #554

Merged
merged 7 commits into from
Oct 23, 2020

Commits on Oct 22, 2020

  1. fix: make subprocess exit set started state

    If an `ipfsd-daemon` instance connects to a running API it does not have a
    `this.subprocess` property, yet if we try to stop the node it tries to access
    that property, leading to this sort of error:
    
    ```
      2) DelegatedPeerRouting
           "after all" hook in "DelegatedPeerRouting":
         TypeError: Cannot read property 'stderr' of null
          at Daemon.stop (node_modules/ipfsd-ctl/src/ipfsd-daemon.js:260:21)
          at processTicksAndRejections (node:internal/process/task_queues:93:5)
          at async Promise.all (index 0)
    ```
    
    This PR moves `this.subprocess` access to where it is created and lets the
    process exiting set `this.started` to `false` as otherwise the state can
    get out of sync with reality.
    achingbrain committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    4a9f22f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dfee2c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Configuration menu
    Copy the full SHA
    beaf794 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1048a5e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    833f901 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d957488 View commit details
    Browse the repository at this point in the history
  5. chore: specify default timeout

    Co-authored-by: Jacob Heun <[email protected]>
    achingbrain and jacobheun authored Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a51c251 View commit details
    Browse the repository at this point in the history