Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs ping should exit non-zero on fail #1041

Closed
jbenet opened this issue Apr 8, 2015 · 2 comments
Closed

ipfs ping should exit non-zero on fail #1041

jbenet opened this issue Apr 8, 2015 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/commands Topic commands

Comments

@jbenet
Copy link
Member

jbenet commented Apr 8, 2015

Today:

> ipfs ping QmaQgJV44WPhTwwPWFYsiuSNeW3o5mNVnYns7PdEpCjdyz
Looking up peer QmaQgJV44WPhTwwPWFYsiuSNeW3o5mNVnYns7PdEpCjdyz
Peer lookup error: routing: not found
> echo $?
0

ipfs/infra#11 (comment)
@jbenet jbenet added the topic/commands Topic commands label Apr 8, 2015
@jbenet jbenet mentioned this issue Apr 8, 2015
Closed
@wking
Copy link
Contributor

wking commented Jun 24, 2015

On Wed, Apr 08, 2015 at 05:37:24AM -0700, Juan Batiz-Benet wrote:

ipfs ping QmaQgJV44WPhTwwPWFYsiuSNeW3o5mNVnYns7PdEpCjdyz
Looking up peer QmaQgJV44WPhTwwPWFYsiuSNeW3o5mNVnYns7PdEpCjdyz
Peer lookup error: routing: not found
echo $?
0

It's not the same command, but I expect the underlying issue here is
the same as #984. I've got a fix for passing error statuses for
streaming commands between a client and daemon in #1413
(commands/http/handler: Write a trailer with any error messages), but
I haven't checked to see if ping or ‘dht get’ are streaming (I'd guess
not, but who knows :).

@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Jan 2, 2016
@whyrusleeping
Copy link
Member

duplicate of #984

@aschmahmann aschmahmann mentioned this issue May 14, 2021
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) topic/commands Topic commands
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbenet @wking @daviddias @whyrusleeping