Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI should return non-zero exit status for errors. #984

Closed
NodeGuy opened this issue Mar 30, 2015 · 3 comments
Closed

CLI should return non-zero exit status for errors. #984

NodeGuy opened this issue Mar 30, 2015 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/commands Topic commands

Comments

@NodeGuy
Copy link

NodeGuy commented Mar 30, 2015

I get:

# ipfs dht get QmVEgmiF8rMEVjmJNket77bCgv42Sbf1JYaYFTUmAGcUc4; echo $?
error: routing: not found
0

I expect:

# ipfs dht get QmVEgmiF8rMEVjmJNket77bCgv42Sbf1JYaYFTUmAGcUc4; echo $?
error: routing: not found
1
@whyrusleeping
Copy link
Member

Yeah, we need to address return codes. Thanks for reporting this

@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) topic/commands Topic commands ready labels Mar 30, 2015
@jbenet
Copy link
Member

jbenet commented Apr 1, 2015

Woah this should be in a sharness test. 

—
Sent from Mailbox

On Sun, Mar 29, 2015 at 5:12 PM, David Braun [email protected]
wrote:

I get:

# ipfs dht get QmVEgmiF8rMEVjmJNket77bCgv42Sbf1JYaYFTUmAGcUc4; echo $?
error: routing: not found
0

I expect:

# ipfs dht get QmVEgmiF8rMEVjmJNket77bCgv42Sbf1JYaYFTUmAGcUc4; echo $?
error: routing: not found
1

Reply to this email directly or view it on GitHub:
#984

@dylanPowers dylanPowers added backlog and removed ready labels May 4, 2015
@wking wking mentioned this issue Jun 24, 2015
Closed
@daviddias daviddias removed the backlog label Jan 2, 2016
@whyrusleeping
Copy link
Member

This has since been resolved

@eDave56 eDave56 mentioned this issue Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) topic/commands Topic commands
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jbenet @daviddias @whyrusleeping @dylanPowers @NodeGuy