Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config to force hash verification for local retrieval #2259

Closed
sivachandran opened this issue Jan 28, 2016 · 3 comments
Closed

Config to force hash verification for local retrieval #2259

sivachandran opened this issue Jan 28, 2016 · 3 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue
Milestone
ipfs-0.4.3-rc1

Comments

@sivachandran
Copy link
Contributor

As per the IRC discussion https://botbot.me/freenode/ipfs/msg/58755967, content hashes are verified only when the content is retrieved from network. The hashes are not verified when retrieved from local storage. But verifying hashes for local retrieval helps us to detect disk corruption. So please provide a config to enable hash verification even for local retrieval.
@rht
Copy link
Contributor

rht commented Jan 28, 2016

👍

@rht
Copy link
Contributor

rht commented Jan 28, 2016

e.g. git-fsck

@whyrusleeping whyrusleeping added the exp/expert Having worked on the specific codebase is important label Feb 1, 2016
kevina added a commit to ipfs-filestore/go-ipfs that referenced this issue May 6, 2016
@kevina
Add basic tests for "add --no-copy".
2c59d6d 
Note that as per issue ipfs#2259 content is not verified for local
retrieval so changing the file content will not always be detected.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
kevina added a commit to ipfs-filestore/go-ipfs that referenced this issue May 6, 2016
@kevina
Add basic tests for "add --no-copy".
2c370b2 
Note that as per issue ipfs#2259 content is not verified for local
retrieval so changing the file content will not always be detected.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
kevina added a commit to ipfs-filestore/go-ipfs that referenced this issue May 6, 2016
@kevina
Add basic tests for "add --no-copy".
aef3dc1 
Note that as per issue ipfs#2259 content is not verified for local
retrieval so changing the file content will not always be detected.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
@RichardLitt RichardLitt added help wanted Seeking public contribution on this issue and removed help wanted Seeking public contribution on this issue labels May 31, 2016
kevina added a commit to ipfs-filestore/go-ipfs that referenced this issue Jun 1, 2016
@kevina
Add basic tests for "add --no-copy".
ded0ac3 
Note that as per issue ipfs#2259 content is not verified for local
retrieval so changing the file content will not always be detected.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
kevina added a commit to ipfs-filestore/go-ipfs that referenced this issue Jun 1, 2016
@kevina
Add basic tests for "add --no-copy".
edc37f6 
Note that as per issue ipfs#2259 content is not verified for local
retrieval so changing the file content will not always be detected.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
kevina added a commit to ipfs-filestore/go-ipfs that referenced this issue Jun 1, 2016
@kevina
Add basic tests for "add --no-copy".
f71b7cd 
Note that as per issue ipfs#2259 content is not verified for local
retrieval so changing the file content will not always be detected.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
kevina added a commit to ipfs-filestore/go-ipfs that referenced this issue Jun 2, 2016
@kevina
Add basic tests for "add --no-copy".
28d18ce 
Note that as per issue ipfs#2259 content is not verified for local
retrieval so changing the file content will not always be detected.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
@whyrusleeping whyrusleeping mentioned this issue Jun 13, 2016
Closed
@whyrusleeping
Copy link
Member

If the option proposed here is added, it should add a check here: https://github.com/ipfs/go-ipfs/blob/master/blocks/blockstore/blockstore.go#L93

to rehash the block (call NewBlock(data) instead of NewBlockWithMultihash) and validate the key matches

@Kubuxu Kubuxu self-assigned this Jun 24, 2016
@Kubuxu Kubuxu mentioned this issue Jun 28, 2016
Merged
@Kubuxu Kubuxu closed this as completed Jun 28, 2016
@Kubuxu Kubuxu added this to the ipfs-0.4.3 milestone Jun 28, 2016
@Kubuxu Kubuxu removed their assignment Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
ipfs-0.4.3-rc1
Development

No branches or pull requests
5 participants
@sivachandran @rht @RichardLitt @whyrusleeping @Kubuxu