Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS_BOOTSTRAP / env-override of config? #251

Closed
jbenet opened this issue Nov 2, 2014 · 9 comments
Closed

IPFS_BOOTSTRAP / env-override of config? #251

jbenet opened this issue Nov 2, 2014 · 9 comments
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue need/community-input Needs input from the wider community topic/commands Topic commands

Comments

@jbenet
Copy link
Member

jbenet commented Nov 2, 2014

As noted in #250, it would be nice to be able to pass in bootstrap addresses as part of an envvar or a cli param. This would make it easier to programmatically create nodes.

What might make sense is to design a seamless way for env vars to override configuration variables, that way we dont have to create multiple ways of changing them.

Maybe a IPFS_CONFIG(_Key)+ ->config(.Key)+ approach. (e.g.IPFS_Config_Bootstrap)... hmm i dont like this.

@whyrusleeping
Copy link
Member

Thats tricky to work out in a way that makes sense....

@btc
Copy link
Contributor

btc commented Nov 2, 2014

@whyrusleeping What challenges do you see?

I don't know of any concrete use cases for other config values. I just know that env bootstrapping is important for Docker.

docker run -e "IPFS_BOOTSTRAP=10.10.10.10" -d go-ipfs

@jbenet
Copy link
Member Author

jbenet commented Nov 2, 2014

i think he means my general suggestion

@btc
Copy link
Contributor

btc commented Nov 2, 2014

Not sure we need to worry about the general case just yet. At least not until a) the pipeline clears up a bit or b) a use case arises that shows importance of a general solution.

@jbenet
Copy link
Member Author

jbenet commented Nov 2, 2014

fair enough

@daviddias
Copy link
Member

We can keep it simple by using env vars and giving the option to extend the default config with --config= option

@RichardLitt RichardLitt added exp/novice Someone with a little familiarity can pick up and removed difficulty: easy labels Feb 2, 2016
@whyrusleeping whyrusleeping added need/community-input Needs input from the wider community help wanted Seeking public contribution on this issue labels Aug 23, 2016
@hannahhoward
Copy link
Contributor

@gmasgras can you comment on whether this is still relevant based on the Docker-izing work you are doing? Should it remain open?

@gmasgras
Copy link

Here is a PR that addresses this issue: #6325

@lidel
Copy link
Member

lidel commented Sep 3, 2021

Continued in #387

@lidel lidel closed this as completed Sep 3, 2021
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue need/community-input Needs input from the wider community topic/commands Topic commands
Projects
None yet
Development

No branches or pull requests

8 participants