Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CIDv1 #3059

Closed
13 tasks
whyrusleeping opened this issue Aug 8, 2016 · 6 comments
Closed
13 tasks

Implement CIDv1 #3059

whyrusleeping opened this issue Aug 8, 2016 · 6 comments
Labels
help wanted Seeking public contribution on this issue

Comments

@whyrusleeping
Copy link
Member

whyrusleeping commented Aug 8, 2016

Once the content ID v1 specification is finalized, we need to begin the work of implementing and integrating it into go-ipfs.

This will contain roughly the following tasks:

  • Implement go-multibase
  • implement binary multicodec
  • Implement 'go-cid' (or whatever we choose to call it)
  • integrate into go-ipfs packages:
    • blocks package. NewBlock should use CID to 'hash' content, and the Key() method should return a CID
    • blocks/key should be able to understand multibase (and when to leave it off for legacy keys?)
    • exchange/bitswap will need to handle sending CIDs and legacy keys in wantlists
    • path:
      • resolver will need to understand CIDs (might not need to change anything here)
      • ParsePath needs to understand multibase
    • core/corehttp/commands/http will need to understand CIDs and multibase encodings
    • TODO: other integration points

Depends on:

Links:

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Aug 8, 2016
@whyrusleeping whyrusleeping added this to the ipld integration milestone Aug 8, 2016
@jbenet
Copy link
Member

jbenet commented Aug 8, 2016

There should be a separate package -- go-cid -- that implements all the
parsing/coding.
On Mon, Aug 8, 2016 at 11:02 Jeromy Johnson [email protected]
wrote:

Once the content ID v1 specification is finalized, we need to begin the
work of implementing and integrating it into go-ipfs.

This will contain roughly the following tasks:

  • Implement go-multibase
  • implement binary multicodec
  • Implement 'go-cid' (or whatever we choose to call it)
  • integrate into go-ipfs packages:
    • blocks package. NewBlock should use CID to 'hash' content, and
      the Key() method should return a CID
    • blocks/key should be able to understand multibase (and when to
      leave it off for legacy keys?)
    • exchange/bitswap will need to handle sending CIDs and legacy keys
      in wantlists
    • path:
      • resolver will need to understand CIDs (might not need to
        change anything here)
      • ParsePath needs to understand multibase
    • core/corehttp/commands/http will need to understand CIDs and
      multibase encodings
    • TODO: other integration points

Depends on:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3059, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIcodw9xq-SS69BpzGDUMleWkD9DRV_ks5qd0T-gaJpZM4JfIqY
.

@ghost
Copy link

ghost commented Aug 22, 2016

  • find a name
    • multiname
    • multid (mul-thai-dee -- maybe too smart?)
    • multiqual (qualifier -- might sound too much like equal)
    • multisym (symbol, which is a synonym of identifier)

@whyrusleeping
Copy link
Member Author

multilarsgierth

On Mon, Aug 22, 2016 at 4:00 PM Lars Gierth [email protected]
wrote:

  • find a name
    • multiname
    • multid (mul-thai-dee -- maybe too smart?)
    • multiqual (qualifier -- might sound too much like equal)
    • multisym (symbol, which is a synonym of identifier)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3059 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABL4HM47iNADl5OXlPgfQE6Z4CQNlt6Eks5qiiohgaJpZM4JfIqY
.

@Kubuxu
Copy link
Member

Kubuxu commented Aug 23, 2016

@lgierth for me it looks like it isn't really a part of multiformats suite, it is just bundle of them to be used as object identifiers in IPLD.

EDIT: s/IPFS/IPLD/

@jbenet
Copy link
Member

jbenet commented Aug 24, 2016

I think it should be part of IPLD, it will be usable in other systems

@whyrusleeping
Copy link
Member Author

This has been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

3 participants