Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIDv1 pin specification doesn't work #3431

Closed
mib-kd743naq opened this issue Nov 28, 2016 · 3 comments
Closed

CIDv1 pin specification doesn't work #3431

mib-kd743naq opened this issue Nov 28, 2016 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
ipld integration

Comments

@mib-kd743naq
Copy link
Contributor

mib-kd743naq commented Nov 28, 2016 •
edited by whyrusleeping
Loading

Version information:

go-ipfs version: 0.4.5-dev-bf9927f
Repo version: 4
System version: amd64/linux
Golang version: go1.7.1

Type:

Bug

Priority:

P2

Description:

$ ipfs pin add zdj7WgpD1zodrFvjBSWMXL2y9dR7z7H1TJdBhrTLZcS4LGPH9
pinned QmZixeZjnNnKrU8acnNR6mnrVmuqHutVKPSvfmDmEthV7D recursively

Did not expect to see a "CIDv0" at the output, likely indicates incorrect index store or somesuch...
@Kubuxu Kubuxu added the kind/bug A bug in existing code (including security flaws) label Nov 28, 2016
@Kubuxu Kubuxu added this to the ipld integration milestone Nov 28, 2016
@whyrusleeping
Copy link
Member

Ah, yeah. I think i know whats happening here. The protobuf nodes always default to generating a cidV0. We might need some way to store cid prefix in the nodes to make sure we generate the correct output cid...

@whyrusleeping whyrusleeping added the status/ready Ready to be worked label Nov 28, 2016
@mib-kd743naq mib-kd743naq mentioned this issue Nov 28, 2016
Closed
@whyrusleeping whyrusleeping mentioned this issue Nov 29, 2016
Merged
@whyrusleeping
Copy link
Member

@mib-kd743naq can you verify that this was fixed in latest master?

@mib-kd743naq
Copy link
Contributor Author

Works as of 0c413de

@Kubuxu Kubuxu closed this as completed Dec 5, 2016
@Kubuxu Kubuxu removed the status/ready Ready to be worked label Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
ipld integration
Development

No branches or pull requests
3 participants
@whyrusleeping @Kubuxu @mib-kd743naq