merkledag: retain cid types when roundtripping through a ProtoNode #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
feat/retain-cid-type
branch
from
d8cb60d
to
cd6d2d2
Compare
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
feat/retain-cid-type
branch
from
79e87eb
to
13f6528
Compare
|
@mib-kd743naq wanna verify that this solves the problems youre seeing in #3427 #3431 ? |
kevina
approved these changes
Dec 4, 2016
|
|
||
| var defaultCidPrefix = cid.Prefix{ | ||
| Codec: cid.DagProtobuf, | ||
| MhLength: -1, |
There was a problem hiding this comment.
Should this really be -1? Does it get set somewhere else. Just double checking, so if you know this is correct than don't worry about it.
There was a problem hiding this comment.
-1 implies "use default length".
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address #3431
License: MIT
Signed-off-by: Jeromy [email protected]