Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPFS Snap #5423

Closed
NatoBoram opened this issue Sep 4, 2018 · 19 comments
Closed

Update IPFS Snap #5423

NatoBoram opened this issue Sep 4, 2018 · 19 comments
Labels
topic/releases Topic releases

Comments

@NatoBoram
Copy link
Contributor

Version information:

go-ipfs version: 0.4.15-rc1-
Repo version: 6
System version: amd64/linux
Golang version: go1.9.2

Type:

Update Request

Description:

Currently, the snap looks like this :

channels:                           
  stable:    v0.4.14     (589) 11MB -
  candidate: v0.4.14     (589) 11MB -
  beta:      v0.4.14     (589) 11MB -
  edge:      v0.4.15-rc1 (696) 11MB -

However, the latest version is 0.4.17. Snaps are damn convenient because they auto-update themselves, they're isolated from the system, and they fit most distros at once. It's easier to install, it allows for auto-completion, and has different release channels.

I'd suggest to anyone new to IPFS to install it using a package manager such as Snap Store instead of the barbarous ways of having random files lay around in the filesystem that's to be added to $PATH and doesn't allow for auto-completion nor auto-updates.

@Stebalien
Copy link
Member

@lgierth any idea who maintains the snap?

@magik6k
Copy link
Member

magik6k commented Sep 5, 2018

IIRC it's built from the release branch, so just pushing the release commit to it should do the trick (It seems to be as outdated as the snap - https://github.com/ipfs/go-ipfs/tree/release)

@Stebalien
Copy link
Member

I tried that but I'm still not seeing a release.

@Stebalien Stebalien added the topic/releases Topic releases label Sep 12, 2018
@magik6k
Copy link
Member

magik6k commented Sep 12, 2018

Oh, it's apparently packaged in https://github.com/elopio/ipfs-snap by @ElOpio

@come-maiz
Copy link
Contributor

oh, sorry, the Travis builds died some time ago. I've just fixed it, basically updating to go1.11 and refreshing the apt repos. Now v0.4.17 is in the candidate channel.

I would apapreciate your help giving it a try. Maybe we can release to stable on Friday.

@Stebalien
Copy link
Member

@ipfs/go-team anyone use Ubuntu?

@come-maiz
Copy link
Contributor

Should work in other stuff too: https://docs.snapcraft.io/core/install

@come-maiz
Copy link
Contributor

btw, you might find this interesting. It's the number of active devices with the snap installed.
ekrankopio de 2018-09-13 11-11-30

@Stebalien
Copy link
Member

That explains the number of 0.4.15 users...

@come-maiz
Copy link
Contributor

Not really. Travis broke before the final release of 0.4.15, so I never moved it to stable.
screenshot from 2018-09-13 15-09-28

@Stebalien
Copy link
Member

Interesting...

@keks
Copy link
Contributor

keks commented Sep 17, 2018

FWIW, snap still is at 0.4.14. @Stebalien did you try pushing another release after the snap was fixed?

@come-maiz
Copy link
Contributor

@keks, are you on the candidate channel? I don't want to push it to stable and trigger updates for everybody before a little more testing.

@cimm
Copy link

cimm commented Dec 15, 2018

A bit off topic but couldn't we add @ElOpio's IPFS snap to the main go-ipfs repository?

I was looking for the IPFS snap and there is nothing indicating this isn't an "official" snap. All links point to the main IPFS website, the snap name isn't prefixed with the maintainer's name, only the publisher name "elopio" looked off. It's not that I don't trust Leo, his name always shows up when looking for snap packages and I think he is deeply involved with the project but it would be cleaner if the snap was published by IPFS itself, wouldn't it?

Maybe the snap is not stable enough yet, fair enough, but we do have snap release channels for that. We don't need a separate repository, do we?

Don't take this the wrong way @ElOpio, my tinfoil hat always itches when I see a snap that's not maintained by the main project. You never know if it's still maintained and the upstream project might forget it even exists (the official IPFS documentation does not mention it for example).

@Stebalien
Copy link
Member

This is both the official and only snap that I know of. If @ElOpio wants, I'd be happy to move it to the ipfs org but I'd like to keep it as a separate repo so @ElOpio can keep maintaining it. Note: @ElOpio's a member of the @snapcore organization.

Alternatively, maybe a note in the README would suffice?

@come-maiz
Copy link
Contributor

@cimm I think everybody should know more their maintainers, what you are doing is very good.

I'm happy to transfer it to the official ipfs name if the team agrees this is a good idea. Or make it clearer that's a package maintained by the community, which is not a bad thing either. Just let me know what should I do.

For the record, I no longer work on snapcraft. Earlier this year I started working on a company that builds on Ethereum called @ZeppelinSolutions, so I continued maintaining a few decentralization snaps that I like a lot, and I'm still a contributor to ubuntu.

And if you are curious about how the ipfs snap is built, take a look at https://github.com/elopio/ipfs-snap
Everything is automatically done by Travis. The only thing I do manually is to move it from candidate to stable after a week or so of testing.

pura vida.

@NatoBoram
Copy link
Contributor Author

I'd just change contact from https://github.com/ipfs/ipfs to https://github.com/elopio/ipfs-snap, that ought to be enough :)

@come-maiz
Copy link
Contributor

Done.

@Stebalien
Copy link
Member

Let's leave it where it is for now. And thanks @ElOpio for maintaining it!

(closing because the actual issue has since been fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/releases Topic releases
Projects
None yet
Development

No branches or pull requests

6 participants