Outdated go-ipfs on the Snap Store breaks IPFS Desktop onboarding experience #7250

bertrandfalguiere · 2020-04-29T16:48:50Z

Context:

snap (snapstore) is now the default package manager for Ubuntu since 20.04
go-ipfs 0.5.0 was just released on several places but not snap (current version : 0.21),
IPFS Desktop was released on several places including snap (current version : 0.11 as expected).

Problem:

go-ipfs is late on snap.
Hence, following instructions from Readme will install an outdated version.
Worst, it will install a version which is incompatible with IPFS Desktop. IPFS Desktop is supposed to be the easy way in IPFS-land (or rather IPFS outer-space... ).

Proposed solution:

Manually bump go-ipfs on snapstore to 0.5.0
Include publishing go-ipfs to snapstore to the regular release process

Alternative, sad solutions:

remove go-ipfs from snapstore
or remove IPFS Desktop from snapstore.

Since IPFS Desktop is supposed to be the onboarding app for naive users, being able to install both it and IPFS via the default package manager is handy.

@ElOpio for the snap update,
@lidel for the IPFS Desktop side

Related: #5423

Stebalien · 2020-04-29T17:01:22Z

Wow, that's really out of date. We need to add snap to our release checklist, apparently.

hsanjuan · 2020-04-29T17:13:14Z

Can we even maintain it ourselves (do we have access)? I think @ElOpio stopped a while ago. I did not have a very good experience with cluster and eventually decided to not sink more time with snaps. I think the maintainers can see a download count for their packages though.

The quickest is to update the Readme and remove snaps while figuring out the mess. Afaik it is the only place where this installation method is suggested.

lidel · 2020-04-29T20:06:13Z

We already maintain ipfs-desktop snap, so I vote for adding it to release checklist.

If @ElOpio checks github notifications: please add me ("lidel" on snapcraft) as maintainer, I'll try to figure it out.
In case he does not, I filled a claim to transfer ipfs to us (pointed we already keep official ipfs-desktop snap up to date)

come-maiz · 2020-05-04T18:09:14Z

Hello IPFS friends. I've added @lidel as a maintainer. Let me know if you need something else.

lidel · 2020-05-06T22:42:07Z

Thank you @ElOpio!

Too late for me to tackle this today, but some quick notes about next steps here:

https://snapcraft.io/docs/go-applications
- sounds like adding snapcraft.yaml to the repo and testing manually-built Snap on local machine would be first step
- when working as expected, open PR to include snapcraft.yaml in the repo
https://snapcraft.io/build
- when we are happy with snapcraft.yaml and it is merged to master we can enable automatic builds using the above service
- Snap supports multiple channels: https://snapcraft.io/docs/channels
  - stable channel would have release versions
  - edge could be built for every change merged to master
    - i think we could even build branches and make sudo snap switch --channel=edge/branch-name ipfs possible
    - iiuc "branch channels" on snap are closed after 30 days of inactivity, so it could be then replaced with regular edge – TBD if we are interested in this

momack2 · 2020-05-23T01:29:30Z

Hey @lidel - is someone tracking this on the desktop team? Can we at least get a read on download count so we can prioritize this vs other work to help folks update?

lidel · 2020-05-25T23:00:43Z

@momack2 I am afraid its on my plate, rest of the GUI team is macOS/Windows.

Metrics for package published at https://snapcraft.io/ipfs are below.
Bit over 1k of mostly Ubuntu users are stuck with this ancient version.

Let me know if I should prioritize this (I don't have any experience with Snap but – cue optimistic theme – it should not take more than 1 day to sort this out).

Stebalien · 2020-06-23T00:30:44Z

@andrew any chance you could take this over?

andrew · 2020-06-23T10:07:17Z

@Stebalien I can take a look, I guess I can just create an ubuntu vm and try to set it up there

fubuloubu · 2020-06-29T15:44:47Z

@lidel you should be able to set up automatic builds/releases in this github repo (with the proper permissions on snapcraft.io) by creating a snapcraft.yml file

olizilla · 2020-07-02T10:08:19Z

Strongly agree with @fubuloubu, (and everyone else on this thread) this seems like a chore that should be automated & traceable, not reliant on individuals. @andrew if you haven't started on this already, I'll take a look at automating it.

olizilla · 2020-07-09T09:35:57Z

We have an updated snapcraft.yaml and documentation over here: https://github.com/ipfs-shipyard/ipfs-snap - I needed to work through all the steps to get my head around building snaps. It's working and i've published a docker image for testing it out. I'm also able to build it reliably directly via snapcraft on a mac now too, which is nice.

Notable changes

fixes an issue that where each update would require the user to re-init a new repo and lose there pins and peerId, by setting $IPFS_PATH to be the $SNAP_USER_COMMON dir. (as raised in IPFS snap copying full block storage with every version (e.g. we're not using the "common" directory) come-maiz/ipfs-snap#12)
removes the home plug as it's using the provided snap common dir for the repo
sets the snap version string from the output of ipfs version --commit
uses the snap go plugin to set the build environment.

The next steps are

Get some eyes and feedback on https://github.com/ipfs-shipyard/ipfs-snap
Temporarily connect https://github.com/ipfs-shipyard/ipfs-snap as the source repo for our snap builds and manually trigger build on the snapstore infra for go-ipfs 0.5.1 and 0.6 as originally proposed by @bertrandfalguiere (this lets us use their infra to build out for arm64, i386, etc (see: i386/arm64 builds come-maiz/ipfs-snap#2 )
PR the snapcraft.yaml here, and if accepted, set ipfs/go-ipfs as the souce repo

@ElOpio I'd love to know if you have any thoughts/concerns/recommendations on https://github.com/ipfs-shipyard/ipfs-snap as it's derived from your work in https://github.com/elopio/ipfs-snap

jacobheun · 2020-07-09T09:43:53Z

Get some eyes and feedback on https://github.com/ipfs-shipyard/ipfs-snap

@rvagg if you have some time to look at this it would be appreciated.

@bertrandfalguiere

Simplify keeping the snap package up to date by including the snapcraft.yaml in the repo. We can then wire up the snapstore to autobuild the package for amd64,i386,arm* etc. Many thanks to @ElOpio for the work of getting ipfs into the snap store in the first place, and to @bertrandfalguiere and @mkg20001 for pushing it forwards. See: https://github.com/ipfs-shipyard/ipfs-snap for more info. Fixes #7250 WIP #3595 License: MIT Signed-off-by: Oli Evans <[email protected]>

olizilla · 2020-07-09T10:41:24Z

of note, it took a few goes for me to get this working locally, and I was initially drifting towards the "sad option" of removing ipfs from the snap store, as we dont have much bandwidth to maintain this, but I'm happy that what is here works and I understand it suffciently to maintain it. Also, even if we wanted to pull the ipfs snap from the store, it is a low friction publishing process, so would likely get published there again, and requires some ci chops to keep it working from a third part repo, so adopting it seems like the best outcome. I am happy to keep an eye on it and review if it causes trouble.

The flow I imaging is we let the snapstore build our snaps for us so the edge channel always has the latest from master, and then promote a build to the stable channel when we cut a release. This could be automated in CI, but it requires putting more complexity in our circle config that I dont think is justified yet. Promoting a build to the stable channel is trivial via the snapstore UI, I can take that on for now. I think the blocker previously has been not knowing the process, and not having access to the account.

come-maiz · 2020-07-09T23:09:23Z

Hey, nice work, I'm so happy you are taking this over.

I'm trying to take some vacations (and failing, of course, that's why I'm here 😞 ) So I will not have time to test it soon, I'm sorry.
Just one quick comment: I think the home plug was there so you could add to IPFS files you are storing in your home directory. With the current configuration, I think you would be able to add only the things in /media.

olizilla · 2020-07-10T08:52:08Z

Thanks for the tip! You are right, I get a permission error when trying to add to ipfs from my home dir. Will revert that.

olizilla · 2020-07-15T14:11:22Z

0.6 is available from the stable snap channel

ubuntu@reasonable-walleye:~$ ipfs version

Command 'ipfs' not found, did you mean:

  command 'ipcs' from deb util-linux
  command 'ipfm' from deb ipfm
  command 'ips' from deb ips

Try: sudo apt install <deb name>

ubuntu@reasonable-walleye:~$ sudo snap install ipfs
2020-07-15T15:09:41+01:00 INFO Waiting for restart...
ipfs 0.6.0-d6e036a88 from Leo Arias (elopio) installed
ubuntu@reasonable-walleye:~$ ipfs version
ipfs version 0.6.0
ubuntu@reasonable-walleye:~$ ipfs daemon --init
Initializing daemon...
go-ipfs version: 0.6.0-d6e036a88
Repo version: 10
System version: amd64/linux
Golang version: go1.14.4
initializing IPFS node at /home/ubuntu/snap/ipfs/common
generating 2048-bit RSA keypair...done
peer identity: QmTxa2VSCsXeXd4cY8eUu5665ZMjJM59TLYgdUeQy9ffLC
to get started, enter:

	ipfs cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme

Swarm listening on /ip4/127.0.0.1/tcp/4001
Swarm listening on /ip4/127.0.0.1/udp/4001/quic
Swarm listening on /ip4/192.168.64.7/tcp/4001
Swarm listening on /ip4/192.168.64.7/udp/4001/quic
Swarm listening on /ip6/::1/tcp/4001
Swarm listening on /ip6/::1/udp/4001/quic
Swarm listening on /p2p-circuit
Swarm announcing /ip4/127.0.0.1/tcp/4001
Swarm announcing /ip4/127.0.0.1/udp/4001/quic
Swarm announcing /ip4/192.168.64.7/tcp/4001
Swarm announcing /ip4/192.168.64.7/udp/4001/quic
Swarm announcing /ip4/91.135.10.211/tcp/46173
Swarm announcing /ip6/::1/tcp/4001
Swarm announcing /ip6/::1/udp/4001/quic
API server listening on /ip4/127.0.0.1/tcp/5001
WebUI: http://127.0.0.1:5001/webui
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/8080
Daemon is ready

bertrandfalguiere added the kind/enhancement A net-new feature or improvement to an existing feature label Apr 29, 2020

olizilla self-assigned this Jul 3, 2020

olizilla mentioned this issue Jul 9, 2020

feat: add snap package configuration #7529

Merged

bertrandfalguiere mentioned this issue Jul 15, 2020

Restore snap publishing on snapcraft ipfs/ipfs-desktop#1551

Closed

aschmahmann closed this as completed in #7529 Jul 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Outdated go-ipfs on the Snap Store breaks IPFS Desktop onboarding experience #7250

Outdated go-ipfs on the Snap Store breaks IPFS Desktop onboarding experience #7250

bertrandfalguiere commented Apr 29, 2020

Stebalien commented Apr 29, 2020

hsanjuan commented Apr 29, 2020

lidel commented Apr 29, 2020

come-maiz commented May 4, 2020

lidel commented May 6, 2020 •

edited

Loading

momack2 commented May 23, 2020

lidel commented May 25, 2020 •

edited

Loading

Stebalien commented Jun 23, 2020

andrew commented Jun 23, 2020

fubuloubu commented Jun 29, 2020 •

edited

Loading

olizilla commented Jul 2, 2020 •

edited

Loading

olizilla commented Jul 9, 2020 •

edited

Loading

jacobheun commented Jul 9, 2020

olizilla commented Jul 9, 2020

come-maiz commented Jul 9, 2020

olizilla commented Jul 10, 2020

olizilla commented Jul 15, 2020

Outdated go-ipfs on the Snap Store breaks IPFS Desktop onboarding experience #7250

Outdated go-ipfs on the Snap Store breaks IPFS Desktop onboarding experience #7250

Comments

bertrandfalguiere commented Apr 29, 2020

Stebalien commented Apr 29, 2020

hsanjuan commented Apr 29, 2020

lidel commented Apr 29, 2020

come-maiz commented May 4, 2020

lidel commented May 6, 2020 • edited Loading

momack2 commented May 23, 2020

lidel commented May 25, 2020 • edited Loading

Stebalien commented Jun 23, 2020

andrew commented Jun 23, 2020

fubuloubu commented Jun 29, 2020 • edited Loading

olizilla commented Jul 2, 2020 • edited Loading

olizilla commented Jul 9, 2020 • edited Loading

jacobheun commented Jul 9, 2020

olizilla commented Jul 9, 2020

come-maiz commented Jul 9, 2020

olizilla commented Jul 10, 2020

olizilla commented Jul 15, 2020

lidel commented May 6, 2020 •

edited

Loading

lidel commented May 25, 2020 •

edited

Loading

fubuloubu commented Jun 29, 2020 •

edited

Loading

olizilla commented Jul 2, 2020 •

edited

Loading

olizilla commented Jul 9, 2020 •

edited

Loading