Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find peer early exit #678

Closed
whyrusleeping opened this issue Jan 27, 2015 · 4 comments
Closed

find peer early exit #678

whyrusleeping opened this issue Jan 27, 2015 · 4 comments
Assignees
@whyrusleeping
Labels
kind/bug A bug in existing code (including security flaws) topic/dht Topic dht

Comments

@whyrusleeping
Copy link
Member

FindPeer may fail to find all addresses associated with a peer, if the first respondee to the query does not have all addresses.

Example:

A FindPeer(X) -> {B, C}

B replies: {X : [127.0.0.1:4001]}
A ends find peer
C replies {X : [76.45.35.75:4001]} and is ignored since A ended the query

I will address this soon, just wanted to file a bug so i remember.
@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Jan 27, 2015
@whyrusleeping whyrusleeping self-assigned this Jan 27, 2015
@jbenet
Copy link
Member

jbenet commented Feb 1, 2015

yeah :/

@whyrusleeping
Copy link
Member Author

I'll verify.

@jbenet jbenet added topic/dht Topic dht need/verification This issue needs verification labels Mar 28, 2015
@whyrusleeping
Copy link
Member Author

not yet fixed AFAICT, i have a changeset im working on that fixes a similar issue with "Get" so i may just apply the same fix to findPeer

@whyrusleeping whyrusleeping removed the need/verification This issue needs verification label Mar 31, 2015
@whyrusleeping
Copy link
Member Author

solved

@jbenet jbenet removed the backlog label Jan 2, 2016
@matyapiro31 matyapiro31 mentioned this issue Mar 17, 2020
Closed
@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
Closed
72 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@TerenceClark
periodicBootstrapInterval should be ticker? (ipfs#678)
81b0285 
* fix: fixLowPeers now runs periodically

Co-authored-by: 刘林欣 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whyrusleeping whyrusleeping

Labels
kind/bug A bug in existing code (including security flaws) topic/dht Topic dht
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbenet @whyrusleeping @dylanPowers