Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs repo gc --quiet is not quiet #7129

Closed
lidel opened this issue Apr 9, 2020 · 4 comments · Fixed by #7147
Closed

ipfs repo gc --quiet is not quiet #7129

lidel opened this issue Apr 9, 2020 · 4 comments · Fixed by #7147
Labels
kind/bug A bug in existing code (including security flaws) P4 Very low priority

Comments

@lidel
Copy link
Member

lidel commented Apr 9, 2020 •
edited
Loading

Version information:

0.5.0-rc1 with badgerds and enabled sharding

Description:

Calling ipfs repo gc --quiet does not seem to do anything,
--quiet still prints every (removed?) CID.

My expectation would be to supress all output, or only print summary at the end.
@lidel lidel added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue P4 Very low priority good first issue Good issue for new contributors labels Apr 9, 2020
@Stebalien
Copy link
Member

Yeah, this is very confusing --quiet just means "don't print 'removed CID'", just print "CID". Instead of removing this, I'd add a "silent" flag to match ipfs add.

@gargdeepak
Copy link

@Stebalien can I please pick this up if no one else is working on it ?

will7200 added a commit to will7200/go-ipfs that referenced this issue Apr 13, 2020
@will7200
feat(cmd): add silent option repo gc command
e3fdc5a 
closes ipfs#7129
will7200 added a commit to will7200/go-ipfs that referenced this issue Apr 13, 2020
@will7200
feat(cmd): add silent option for command repo gc
13dc59b 
closes ipfs#7129
@will7200 will7200 mentioned this issue Apr 13, 2020
Merged
@hsanjuan
Copy link
Contributor

@Stebalien can I please pick this up if no one else is working on it ?

Go ahead (adding the --silent flag).

@hsanjuan hsanjuan removed the help wanted Seeking public contribution on this issue label Apr 14, 2020
@hsanjuan
Copy link
Contributor

Ah sorry @gargdeepak , there is a PR already for this (#7147).

@lidel lidel removed the good first issue Good issue for new contributors label Apr 15, 2020
@lidel lidel added help wanted Seeking public contribution on this issue and removed help wanted Seeking public contribution on this issue labels Feb 18, 2022
lidel pushed a commit to will7200/go-ipfs that referenced this issue Feb 18, 2022
@will7200 @lidel
feat(cmd): add silent option repo gc command
9b679af 
closes ipfs#7129
lidel added a commit that referenced this issue Feb 18, 2022
@will7200 @lidel
feat(cmd): add silent option for repo gc (#7147)
bfa9d3d 
* feat(cmd): add silent option repo gc command

closes #7129

* test(cmd): add test case for silent option for command repo gc
* fix: no emit on server with --silent

This removes unnecessary send to the client that does not care

Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P4 Very low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cmd): add silent option for command repo gc will7200/go-ipfs
4 participants
@lidel @Stebalien @gargdeepak @hsanjuan