Fix/routing put cmd #10205
Merged
Fix/routing put cmd #10205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the error is an offline error
hacdias
approved these changes
Nov 7, 2023
aschmahmann
added
the
skip/changelog
hacdias
added a commit
that referenced
this pull request
Nov 8, 2023
* fix(commands): routing put command returns the IPNS ID rather than the host's ID * fix(commands): routing put command errors with the allow-offline hint if the error is an offline error * fix: test expects correct error message --------- Co-authored-by: Henrique Dias <[email protected]>
hacdias
added a commit
that referenced
this pull request
Nov 8, 2023
* fix(commands): routing put command returns the IPNS ID rather than the host's ID * fix(commands): routing put command errors with the allow-offline hint if the error is an offline error * fix: test expects correct error message --------- Co-authored-by: Henrique Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two oddities in the
routing putcommand (noticed while setting up gateway conformance tests):Routing().PutThere's an implicitly breaking change here where
/pkrecords used to work but won't anymore due to the check on a valid IPNS name, although/pkrecords are not mentioned in the help text at all. This is easily fixable, but before fixing seems like we should agree on if we should (and if so add a test)